Repository navigation
Fix SCM Persistence Clocks Across Unknown Observations - #253
Merged
Merged
Conversation
- Add configurable queue maximum length and message TTL - Set quorum delivery limit default to 5 - Declare matching arguments for classic and quorum queues - Update runtime options, validation, configuration, and documentation - Add topology compatibility regression tests - Verify redeclaration of existing Eweka and Giganews quorum queues
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a
SilentConsumerMonitorstate-machine defect where time spent without reliable observations incorrectly counted toward fault-opening and fault-resolution persistence windows.Previously,
Unknownobservations prevented state transitions but left the persistence clock origins unchanged. When observations resumed, an outage could therefore trigger a false-positive alert or prematurely resolve an existing alert.Changes
Unknownobservation intervals.Validation
Scope
This is a targeted correctness fix. It does not change monitoring thresholds, event contracts, RabbitMQ topology, or reconciliation ownership.
The monitor remains observational; existing reconciliation behavior is unchanged.