Skip to content

Fix SCM Persistence Clocks Across Unknown Observations - #253

Merged
enteriaza merged 2 commits into
masterfrom
scm-persistence
Oct 26, 2026
Merged

enteriaza merged 2 commits into
masterfrom
scm-persistence

Conversation

@enteriaza

Copy link
Copy Markdown
Collaborator

Summary

Fixes a SilentConsumerMonitor state-machine defect where time spent without reliable observations incorrectly counted toward fault-opening and fault-resolution persistence windows.

Previously, Unknown observations prevented state transitions but left the persistence clock origins unchanged. When observations resumed, an outage could therefore trigger a false-positive alert or prematurely resolve an existing alert.

Changes

  • Freeze persistence clocks across Unknown observation intervals.
  • Preserve existing alert state while observations are unavailable.
  • Resume persistence timing correctly when reliable observations return.
  • Add three regression tests covering state-machine and engine behavior.
  • Update implementation comments and document the correctness audit.

Validation

  • SilentConsumerMonitor tests: 63 passed.
  • Full BackFillerService test suite: 1,607 passed.
  • Release x64 solution build: succeeded with zero warnings.
  • Formatting checks: passed for changed files.

Scope

This is a targeted correctness fix. It does not change monitoring thresholds, event contracts, RabbitMQ topology, or reconciliation ownership.

The monitor remains observational; existing reconciliation behavior is unchanged.

@enteriaza enteriaza self-assigned this Oct 26, 2026
@enteriaza enteriaza added the bug Something isn't working label Oct 26, 2026
- Add configurable queue maximum length and message TTL
- Set quorum delivery limit default to 5
- Declare matching arguments for classic and quorum queues
- Update runtime options, validation, configuration, and documentation
- Add topology compatibility regression tests
- Verify redeclaration of existing Eweka and Giganews quorum queues
@enteriaza
enteriaza merged commit b192774 into master Oct 26, 2026
7 checks passed
@enteriaza
enteriaza deleted the scm-persistence branch October 26, 2026 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant