Repository navigation
Fix BackFiller settlement, NNTP session reuse, and connection pool lifecycle - #248
Merged
Merged
Conversation
ACK and reply ProviderFailure, UnexpectedFailure, and RetentionRejected so completed work is not redelivered without a client reply. Handle mandatory unroutable replies as terminal NACK without requeue. Keep NNTP sessions reusable for ARTICLE 403/500/501/503, map 451 to ArticleNotFound, and retain pool capacity until disposal completes. Add connectionId and retirement-cause diagnostics, the gated E2E Stress harness, regression tests, and related CodeQL remediations.
Skip host-specific corpus assertions when the required Windows corpus is unavailable. Replace generic Stress exception handlers with typed handling, ensure reply-client cleanup in finally, and fix null-flow assertions flagged by CodeQL.
Document all applicable production, test, helper, and Stress declarations, including private and internal members. Correct stale documentation and close missing XML documentation gaps. Record the namespace documentation limitation (CS1587) in the audit report. Release x64 builds pass with zero warnings or errors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Summary
This PR improves BackFiller correctness and reliability by correcting terminal work settlement, preserving reusable NNTP sessions after selected ARTICLE responses, enforcing connection pool capacity throughout session disposal, and strengthening operational diagnostics.
It also adds regression coverage and a gated end-to-end stress harness.
Changes
1. Correct terminal work settlement
ProviderFailure,UnexpectedFailure, andRetentionRejected, preventing completed work from being repeatedly redelivered without a client reply.Cancelledwork.RabbitMqPublicationUnroutableExceptionand terminally NACK without requeue, recordingReplyUnroutableTerminal.2. Improve NNTP ARTICLE response handling
403,500,501, and503, provided the connection remains synchronised.451asArticleNotFound.3. Enforce connection pool capacity
_createdrather than_live, preventing disposal in progress from prematurely freeing capacity.4. Improve operational diagnostics
ConnectionIdcorrelation.5. Expand verification and address CodeQL findings
Verification
Review notes