Repository navigation
feat(storage): implement per-spool capacity management, LFU eviction, and ARTICLE retrieval - #247
Merged
Merged
Conversation
feat(storage): enforce per-spool capacity, LFU eviction, and ARTICLE retrieval
There was a problem hiding this comment.
CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR extends VectorNNTP.StorageService with active per-spool capacity management, LFU-based eviction, NNTP article retrieval, and improved ingress resource control. It also consolidates CanonicalV1 delivery framing into Common and adds opt-in diagnostic benchmarks for investigating filesystem performance and resilience.
Storage Capacity and Eviction
NNTP Protocol and Ingress
ARTICLE <message-id>retrieval from published CanonicalV1 articles.Queue Management and Lifecycle
Shared Delivery Framing
Diagnostics and Testing
Validation Notes
The current working-tree review identified previous successful test and build results, but the complete set of current changes has not yet been revalidated together. Full-tree validation should be completed before merging.
The filesystem diagnostics are investigative tools; this PR does not claim to resolve the observed filesystem tail-latency issue.