Repository navigation
Fix CanonicalV1 double-stuffing during article persistence - #246
Merged
Merged
Conversation
Preserve CanonicalV1 body bytes when rewriting article Path and Date headers before spooling. Add explicit body-mode documentation and regression coverage for dot-leading lines across the TAKETHIS-to-spool pipeline. Keep queue-admission acknowledgement semantics unchanged.
Remove the redundant CanonicalBodyMode check from the materialiser's body-copy condition. PreserveCanonicalBody already sets extraDots to zero, so behaviour remains unchanged while resolving CodeQL alert #2168.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes double-stuffing of dot-leading article body lines during storage persistence by preserving the existing CanonicalV1 body when rewriting article headers.
Changes
PreserveCanonicalBodymode to the article canonical materialiser.TAKETHIS→ queue → worker → spool test.239does not wait for disk persistence.Validation
dotnet format --verify-no-changespassed for the touched files.