Repository navigation
Reduce Allocations in StorageService NNTP Ingestion - #245
Merged
Merged
Conversation
- Replace the VATP listener and session with NNTP STREAMING ingestion - Route TAKETHIS articles through the existing accepted-article queue - Remove obsolete VATP transport components, tests, and configuration - Fix pipelined command buffer corruption and oversized article handling - Add NNTP ingestion and large-residue regression tests - Update StorageService lifecycle tests and protocol documentation - Preserve the existing fleet advertisement wire contract
- Reuse session-local read scratch buffer - Reduce initial article assembly buffer rental - Avoid unnecessary command and message-ID allocations - Skip debug hex formatting when debug logging is disabled - Add in-memory ingestion allocation measurements - Isolate transport counter tests and restore exact assertions - Preserve NNTP framing and buffer ownership semantics
- Remove forced garbage collection from allocation measurements - Remove an unused destuffed article assignment - Document expected cancellation during benchmark shutdown - Preserve benchmark measurement and ingestion behaviour
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Optimises the StorageService NNTP ingestion hot path to reduce per-article allocations while preserving protocol correctness, buffer ownership, and queue handoff semantics.
Changes
TAKETHIShandling and buffer ownership guarantees.Validation
TAKETHISand transport timeout coverage.dotnet format --verify-no-changespassed.Performance Notes
The in-memory benchmark measured a reduction from approximately 5,659 to 3,259–3,260 allocated bytes per article, around 42% less allocation under the same harness.
This is a relative measurement; the harness also includes client-side status-line processing and allocations, so the absolute figure is not server-only.
TLS throughput measurements remain inconclusive. Five optimised-build runs varied from 10,624 to 16,613 accepted articles over three seconds, so no definitive throughput improvement is claimed.