Skip to content

Integrate StorageService into VectorNNTPD solution and release pipeline - #243

Merged
enteriaza merged 10 commits into
masterfrom
StorageService-Import
Oct 23, 2026
Merged

enteriaza merged 10 commits into
masterfrom
StorageService-Import

Conversation

@enteriaza

Copy link
Copy Markdown
Collaborator

Summary

Integrates StorageService into the VectorNNTPD solution as a first-class service, aligning project and assembly identities, configuration, Native AOT publishing, release packaging, and systemd deployment with existing repository conventions.

Changes

  • Add StorageService projects

    • Add VectorNNTPD.StorageService and VectorNNTPD.StorageService.Tests.
    • Register both projects in VectorNNTPD.slnx.
    • Align production and test assembly names with the VectorNNTPD naming convention.
  • Align configuration and shared infrastructure

    • Rename the primary and Development configuration files to the VectorNNTPD.StorageService naming convention.
    • Update configuration loading, tests, fixtures, and publish rules.
    • Update the two InternalsVisibleTo entries in VectorNNTPD.Common.csproj to match the new assembly identities.
    • Preserve the existing VectorNNTPD.Common APIs and implementation.
  • Integrate release and deployment

    • Extend tools/Publish-Release.ps1 to package BackFillerService and StorageService.
    • Include Windows and Linux Native AOT publishing and CI validation.
    • Add the StorageService systemd unit and environment example.
    • Update release documentation and obsolete configuration-name checks.
  • Add startup smoke validation

    • Add an isolated StorageService configuration and logging smoke path.
    • Add StorageService smoke-test coverage and CI workflow steps.
    • Scope Native AOT warning suppressions to StorageService publishing.

Validation

  • StorageService.Tests: 400 passed
  • Common.Tests: 1,176 passed (previous validation)
  • StorageService and test projects: build succeeded with zero warnings.
  • dotnet format --verify-no-changes: passed.
  • Windows Native AOT publish and executable smoke: passed.
  • Linux Native AOT release packaging: passed.
  • Linux published-executable smoke: passed locally under WSL against the release binary available at validation time.

Notes

  • The startup smoke validates configuration loading, logging initialization, and the startup checkpoint. It does not exercise the complete production host lifecycle or external dependencies.
  • GitHub CI has not yet validated the final unpushed working-tree changes.
  • No changes to Common APIs or implementation are included; the two authorized friend-assembly identity entries are updated.

@enteriaza enteriaza self-assigned this Oct 22, 2026
@enteriaza enteriaza added the enhancement New feature or request label Oct 22, 2026

@github-advanced-security github-advanced-security AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

- Fix StorageService CodeQL findings around admission handling, resource cleanup, native interop, and latency comparison
- Harden ArticleIndexDatabase reader initialization and cleanup
- Restore release validation messages for Linux environment examples
- Make DbDir validation tests platform-independent
- Fix cache fleet composition test compatibility on Linux
- Fix capacity-wait logging race in StorageVatpSession
- Harden admission handling and resource cleanup
- Retain console logging writer for process lifetime
- Migrate filesystem free-space interop to LibraryImport
- Use deterministic spool latency comparison
- Strengthen backpressure and spool selection tests
- Replace unnecessary directory P/Invoke calls with managed I/O
- Modernize Windows storage interop with LibraryImport
- Clarify storage admission ownership and release semantics
- Use deterministic spool latency comparison with path tie-breaking
- Clarify console writer lifetime and ownership
- Add directory initialization and spool selection regression tests
- Add shared relative-path validation and containment checks
- Validate logging application names before filename construction
- Harden article index, spool registry, and write-probe paths
- Validate Linux sysfs device identifiers
- Add path validation and logging regression tests
- Log unexpected connection drain faults without interrupting shutdown
- Distinguish routine peer disconnects from unexpected connection failures
- Narrow shared configuration stop cancellation handling
- Add regression tests for drain faults, peer disconnects, and cancellation semantics
- Reconcile CodeQL findings and update audit disposition

Validation: Release build succeeded with zero warnings; 431 tests passed; format verification passed; CodeQL reports 61 findings, with zero empty-catch alerts.
- Apply fatal-exception filters to production isolation handlers
- Simplify nested conditions in ArticleIndexWriter
- Reconcile PR #243 annotations against current CodeQL results
- Update findings inventory and disposition documentation

Validation: Release build succeeded with zero warnings; 431 tests passed; format verification passed; CodeQL findings reduced from 61 to 49.
- Ensure reservation binding and teardown are coordinated
- Make reservation release and admission exit exactly-once
- Transfer reservation ownership before queue commit
- Prevent teardown from releasing a reservation claimed by commit
- Dispose partially initialized index readers safely
- Correct Windows disk performance handle validation
- Remove redundant assignments and simplify equivalent LINQ paths
- Add reservation ownership and concurrent teardown regression tests
- Strengthen back-pressure admission accounting assertions
- Preserve short-circuit behavior in block device identity lookup
- Clarify configured sink application without changing processing semantics
- Suppress unavoidable native thread-time calls using the established CodeQL convention
- Correct invalid-handle detection in disk performance reader
- Use a portable invalid handle sentinel in regression tests
- Add cross-platform invalid-handle coverage
@enteriaza
enteriaza merged commit 37dff02 into master Oct 23, 2026
7 checks passed
@enteriaza
enteriaza deleted the StorageService-Import branch October 23, 2026 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants