Repository navigation
Integrate StorageService into VectorNNTPD solution and release pipeline - #243
Merged
Merged
Conversation
There was a problem hiding this comment.
CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
- Fix StorageService CodeQL findings around admission handling, resource cleanup, native interop, and latency comparison - Harden ArticleIndexDatabase reader initialization and cleanup - Restore release validation messages for Linux environment examples - Make DbDir validation tests platform-independent - Fix cache fleet composition test compatibility on Linux
- Fix capacity-wait logging race in StorageVatpSession - Harden admission handling and resource cleanup - Retain console logging writer for process lifetime - Migrate filesystem free-space interop to LibraryImport - Use deterministic spool latency comparison - Strengthen backpressure and spool selection tests
- Replace unnecessary directory P/Invoke calls with managed I/O - Modernize Windows storage interop with LibraryImport - Clarify storage admission ownership and release semantics - Use deterministic spool latency comparison with path tie-breaking - Clarify console writer lifetime and ownership - Add directory initialization and spool selection regression tests
- Add shared relative-path validation and containment checks - Validate logging application names before filename construction - Harden article index, spool registry, and write-probe paths - Validate Linux sysfs device identifiers - Add path validation and logging regression tests
- Log unexpected connection drain faults without interrupting shutdown - Distinguish routine peer disconnects from unexpected connection failures - Narrow shared configuration stop cancellation handling - Add regression tests for drain faults, peer disconnects, and cancellation semantics - Reconcile CodeQL findings and update audit disposition Validation: Release build succeeded with zero warnings; 431 tests passed; format verification passed; CodeQL reports 61 findings, with zero empty-catch alerts.
- Apply fatal-exception filters to production isolation handlers - Simplify nested conditions in ArticleIndexWriter - Reconcile PR #243 annotations against current CodeQL results - Update findings inventory and disposition documentation Validation: Release build succeeded with zero warnings; 431 tests passed; format verification passed; CodeQL findings reduced from 61 to 49.
- Ensure reservation binding and teardown are coordinated - Make reservation release and admission exit exactly-once - Transfer reservation ownership before queue commit - Prevent teardown from releasing a reservation claimed by commit - Dispose partially initialized index readers safely - Correct Windows disk performance handle validation - Remove redundant assignments and simplify equivalent LINQ paths - Add reservation ownership and concurrent teardown regression tests - Strengthen back-pressure admission accounting assertions
- Preserve short-circuit behavior in block device identity lookup - Clarify configured sink application without changing processing semantics
- Suppress unavoidable native thread-time calls using the established CodeQL convention - Correct invalid-handle detection in disk performance reader - Use a portable invalid handle sentinel in regression tests - Add cross-platform invalid-handle coverage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Integrates StorageService into the VectorNNTPD solution as a first-class service, aligning project and assembly identities, configuration, Native AOT publishing, release packaging, and systemd deployment with existing repository conventions.
Changes
Add StorageService projects
VectorNNTPD.StorageServiceandVectorNNTPD.StorageService.Tests.VectorNNTPD.slnx.Align configuration and shared infrastructure
VectorNNTPD.StorageServicenaming convention.InternalsVisibleToentries inVectorNNTPD.Common.csprojto match the new assembly identities.VectorNNTPD.CommonAPIs and implementation.Integrate release and deployment
tools/Publish-Release.ps1to package BackFillerService and StorageService.Add startup smoke validation
Validation
dotnet format --verify-no-changes: passed.Notes