Repository navigation
Replace Path.Combine with Path.Join - #241
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace
Path.CombinewithPath.Joinacross VectorNNTPD to address CodeQL'scs/path-combinereliability findings.Path.Combinediscards preceding path components when a subsequent component is rooted.Path.Joinpreserves the preceding components, preventing this unexpected path-construction behaviour.Changes
Path.Combinecall sites across 13 existing files.AcmePathJoinTeststo verify rooted-segment behaviour, ACME directory layout, and the intended path-joining convention.ApplicationLocalPathpath-containment handling unchanged.Validation
Common.Tests: 1,149 passed on retry after initial ACME static-hook race failures.BackFillerService.Tests: 1,400 passed.dotnet format --verify-no-changes: passed.win-x64andlinux-x64passed.cs/path-combinefindings in SARIF.Notes
The GitHub baseline contained 98 open
cs/path-combinealerts, while the source audit identified 103 call sites. Remote GitHub Security results and CI have not yet been revalidated against this change; those results remain pending a push and subsequent analysis.