Skip to content

Derive Article Work queue topology from RabbitMQ hosts - #240

Merged
enteriaza merged 3 commits into
masterfrom
195-bug-enforce-article-work-quorum-health-and-delivery-limit
Oct 21, 2026
Merged

enteriaza merged 3 commits into
masterfrom
195-bug-enforce-article-work-quorum-health-and-delivery-limit

Conversation

@enteriaza

Copy link
Copy Markdown
Collaborator

Summary

Derive Article Work queue topology from the configured RabbitMQ:Hosts array, removing the need to configure quorum initial group size independently.

  • Single host: Declare classic queues without quorum-specific arguments or quorum health checks.
  • Multiple hosts: Declare quorum queues with x-quorum-initial-group-size derived from the number of unique configured hosts.
  • Reject empty host lists, duplicate hosts, and configurations exceeding the supported seven-host limit.
  • Remove the redundant ArticleWorkQuorumInitialGroupSize setting.
  • Preserve fail-closed quorum health checks for multi-host deployments.
  • Retain delivery-limit enforcement and handle missing delivery-count metadata according to queue type.
  • Improve diagnostics for queue declaration failures without deleting or recreating existing queues.

Operational considerations

Changing the configured host count from one to multiple hosts, or vice versa, changes the desired queue type. Existing queues cannot be converted through redeclaration alone and require an explicit operator-managed migration.

All configured hosts in a multi-host deployment are expected to belong to the same RabbitMQ cluster. Quorum membership health requires the RabbitMQ Management API to be configured and available.

Exhausted Article Work messages are rejected without requeue; no dead-letter exchange is configured by this change.

Validation

  • Focused topology, quorum-health, settlement, and factory tests passed (86).
  • Common RabbitMQ tests passed (18).
  • VectorNNTPD.BackFillerService.Tests: 1,400 passed.
  • VectorNNTPD.Common.Tests: 1,146 passed.
  • Release x64 build passed.
  • dotnet format --verify-no-changes passed.
  • CodeQL completed successfully (exit 0).

An initial BackFillerService test run exposed a lifecycle assertion that still expected quorum topology with a single configured host. The assertion was corrected, and the subsequent full run passed.

The previously identified ACME static-hook parallel-test race remains a known issue reproduced on the base branch; it did not recur in this validation run.

Fixes #195

@enteriaza enteriaza self-assigned this Oct 21, 2026
@enteriaza enteriaza added the bug Something isn't working label Oct 21, 2026
Use source-generated JSON metadata for quorum health responses.
Preserve fail-closed Management API health checks.
Correct test HTTP response ownership and disposal.
Narrow Management API exception handling.
Refine configured-host filtering without changing validation semantics.

Co-authored-by: Cursor <cursoragent@cursor.com>
@enteriaza
enteriaza merged commit d84482d into master Oct 21, 2026
7 checks passed
@enteriaza
enteriaza deleted the 195-bug-enforce-article-work-quorum-health-and-delivery-limit branch October 21, 2026 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Quorum Article Work queues are not checked for membership or a delivery limit

2 participants