Repository navigation
Conversation
Use source-generated JSON metadata for quorum health responses. Preserve fail-closed Management API health checks. Correct test HTTP response ownership and disposal. Narrow Management API exception handling. Refine configured-host filtering without changing validation semantics. Co-authored-by: Cursor <cursoragent@cursor.com>
enteriaza
deleted the
195-bug-enforce-article-work-quorum-health-and-delivery-limit
branch
October 21, 2026 20:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Derive Article Work queue topology from the configured
RabbitMQ:Hostsarray, removing the need to configure quorum initial group size independently.x-quorum-initial-group-sizederived from the number of unique configured hosts.ArticleWorkQuorumInitialGroupSizesetting.Operational considerations
Changing the configured host count from one to multiple hosts, or vice versa, changes the desired queue type. Existing queues cannot be converted through redeclaration alone and require an explicit operator-managed migration.
All configured hosts in a multi-host deployment are expected to belong to the same RabbitMQ cluster. Quorum membership health requires the RabbitMQ Management API to be configured and available.
Exhausted Article Work messages are rejected without requeue; no dead-letter exchange is configured by this change.
Validation
VectorNNTPD.BackFillerService.Tests: 1,400 passed.VectorNNTPD.Common.Tests: 1,146 passed.dotnet format --verify-no-changespassed.An initial BackFillerService test run exposed a lifecycle assertion that still expected quorum topology with a single configured host. The assertion was corrected, and the subsequent full run passed.
The previously identified ACME static-hook parallel-test race remains a known issue reproduced on the base branch; it did not recur in this validation run.
Fixes #195