Repository navigation
Fix retention sweep after backward clock adjustments - #235
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #189.
Ensure the retention sweep removes all expired articles even when the system wall clock moves backward and expiry timestamps no longer follow insertion order.
Root cause
ExpireEligibleLockedwalked the insertion-order linked list and stopped at the first entry whoseExpiresUtcwas later than the current time. This assumed expiration order matched insertion order.After a backward clock adjustment, a later-admitted article can have an earlier expiration timestamp than an older entry. The sweep would stop at the older, unexpired entry and leave subsequent expired articles resident, consuming retained-payload capacity unnecessarily.
Changes
ExpiresUtc <= now.SetUtcNowtoManualTimeProviderto simulate backward clock adjustments without relying on real-time delays.ArticleRetentionSweepClockTestsfor backward-clock expiry, multiple expired entries separated by unexpired entries, exact expiry boundaries, and FIFO behaviour.Validation
VectorNNTPD.BackFillerService.Tests: 1,328 passeddotnet format VectorNNTP.slnx --verify-no-changes: passedtools/Invoke-CodeQlAnalysis.ps1: completed successfully; six pre-existingNntpSessionPoolfindings remain.Correctness guarantees
ExpiresUtc <= nowis eligible for removal during the sweep, regardless of insertion position.