Repository navigation
Prevent CacheListener accept-error busy loops - #233
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #187 by preventing repeated socket-accept failures from creating a tight retry loop in
CacheListenerService.AcceptLoopAsync.Previously,
SocketExceptionwas caught and immediately retried while the service was running. A persistent accept failure could consume a CPU core indefinitely without logging or transitioning the listener into a failed state.Changes
InvalidOperationExceptionwith the originalSocketExceptionas its inner exception, allowing the existingExecutionfault path to handle unexpected termination.Retiringstate.Retry Policy
All socket errors currently use the same retry policy. Error-specific classification and exponential backoff are outside the scope of this change.
Validation
CacheListenerServiceTests: 29 passeddotnet format --verify-no-changes: passedCloses #187.