Repository navigation
Conversation
Recognize CR, LF, and CRLF as line boundaries when locating dot-leading body lines, matching parser line accounting. Add regression coverage for bare CR, LF, and repeated CR without changing the exclusive-CRLF delivery requirement.
Use responsive servers in the never-firing replenish timer test so it measures cancellation independently of stalled QUIT writes. Retain explicit timer-armed synchronization and bounded cleanup.
enteriaza
deleted the
168-bug-protocol-body-dot-stuffing-ignores-bare-cr-line-breaks
branch
October 20, 2026 04:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #168
Fix body dot-stuffing so CR, LF, and CRLF are consistently recognized as line boundaries, matching the parser's existing line-accounting behavior.
Changes
ArticleBodyWireStufferto recognize CR, LF, and CRLF when locating body line boundaries.ArticleRecord.mdto document the line-boundary behavior.Validation
ArticleBodyWireStufferTests— 27 passedVectorNNTPD.Common.Tests— 957 passedVectorNNTPD.BackFillerService.Tests— 1,266 passeddotnet format --verify-no-changes— passedCompatibility and notes
The parser's existing admission behavior is unchanged. Bare CR and bare LF bodies may still be retained, but
IsFrameablecontinues to require CRLF line endings for NNTP delivery. The wire stuffer detects line starts consistently without rewriting the original body bytes.Local CodeQL results do not replace GitHub code scanning.