Repository navigation
Conversation
Accept valid Path folding whitespace before delimiters and reject folds in invalid positions. Preserve interior !! verification markers without transferring them when duplicate tracker hops are removed. Add regression coverage for parsing and canonicalization.
enteriaza
deleted the
167-bug-protocol-folded-path-is-rejected-and-diagnostics-are-deleted
branch
October 19, 2026 20:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #167
Fix Path header validation and canonicalization to accept valid folding whitespace while preserving the verification semantics of
!!diagnostic markers.Changes
!, folds inside a Path component, bare CR/LF, and malformed continuations.!!verification markers when both associated Path hops survive canonicalization.ArticleRecord.mdand add regression coverage for folded Path values, diagnostic markers, tracker deduplication, and invalid inputs.Validation
ArticlePathCanonicalizerTests— 34 passedVectorNNTPD.Common.Tests— 944 passedVectorNNTPD.BackFillerService.Tests— 1,266 passeddotnet format VectorNNTPD.slnx --verify-no-changes— passedCompatibility and notes
Valid folded Path values are now accepted, while folds in invalid positions are rejected. Interior
!!markers retain their verification meaning, and markers are not reassigned when duplicate tracker hops are removed.The existing handling of
diag-otheranddiag-deprecatedforms is unchanged.TryWriteCanonicalPathcontinues to rely on its caller to enforce the 8,192-byte Path limit.Local CodeQL results do not replace GitHub code scanning.
Fixes #167