Repository navigation
Accept folded Newsgroups header values - #211
Merged
enteriaza merged 1 commit intoOct 19, 2026
Merged
Conversation
Unfold valid CRLF continuations before validating Newsgroups, allow whitespace around group separators, and reject whitespace inside group names. Add parser and overview regression coverage.
enteriaza
deleted the
166-bug-protocol-folded-newsgroups-values-are-rejected
branch
October 19, 2026 19:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #166
Fix Newsgroups header validation to accept valid folded values in accordance with RFC 5536 §3.1.4, while rejecting whitespace that splits a newsgroup name.
Changes
InvalidNewsgroups.ArticleRecord.mdto document the validation behavior.Validation
NntpArticleParserTests— 103 passedOverviewArticleV1CodecTests— 27 passedVectorNNTPD.Common.Tests— 928 passedVectorNNTPD.BackFillerService.Tests— 1,266 passeddotnet format VectorNNTPD.slnx --verify-no-changes— passedCompatibility
Valid folded Newsgroups values are now accepted, with group names preserved correctly in overview data. Whitespace inside a group name is rejected rather than silently accepted.
Note: CodeQL results are from local analysis and do not replace GitHub code scanning. Leading and trailing whitespace acceptance remains broader than the strict RFC 5536 grammar.