Repository navigation
Conversation
Enforce the RFC 5536 single-Date requirement before date resolution, preventing CanonicalUtc from disagreeing with the Date field retained for overview and transfer. Add regression coverage for duplicate and malformed Date headers.
enteriaza
deleted the
165-bug-article-a-later-date-header-can-disagree-with-the-stored-date-field
branch
October 19, 2026 19:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #165
Reject NNTP articles containing multiple
Dateheaders before date resolution, preventingCanonicalUtcfrom disagreeing with the Date field retained for overview and transfer.Changes
NntpArticleParseFailureCode.DuplicateDate.Dateheaders before invokingArticleDateHeaderResolver.Dateheader, including fallback toInjection-Dateand other candidate names when applicable.Daterequirement and rejection behavior.Validation
VectorNNTPD.Common.Tests— 913 passedVectorNNTPD.BackFillerService.Tests— 1,266 passeddotnet format VectorNNTPD.slnx --verify-no-changes— passedCompatibility
Articles containing duplicate
Dateheaders are now rejected, even if both values are valid or represent the same instant. Articles with a singleDateheader retain their existing behavior.The duplicate check runs before canonical date resolution and materialization, preventing an accepted article from publishing a canonical timestamp derived from a different header occurrence than the one stored for downstream processing.
Fixes #165