Skip to content

Expand news date timezone abbreviation coverage - #209

Merged
enteriaza merged 1 commit into
masterfrom
164-bug-date-cst-is-parsed-as-0800-while-cdt-is-us-central
Oct 19, 2026
Merged

enteriaza merged 1 commit into
masterfrom
164-bug-date-cst-is-parsed-as-0800-while-cdt-is-us-central

Conversation

@enteriaza

Copy link
Copy Markdown
Collaborator

Summary

Closes #164

Correct the CST timezone mapping and expand the curated timezone abbreviation table to improve recognition of international and historical Usenet article dates.

Changes

  • Correct CST from +08:00 to -06:00, following the North American news-date convention.
  • Preserve CDT at -05:00 and the existing EST/EDT, MST/MDT, and PST/PDT mappings.
  • Add international timezone abbreviations covering the Americas, Europe, Africa, the Middle East, Asia, Australia, New Zealand, and the Pacific.
  • Extend coverage for fractional-hour offsets, including +04:30, +06:30, +12:45, +13:45, and -09:30.
  • Document ambiguous abbreviations and the chosen conventional interpretations.
  • Label historical daylight abbreviations explicitly, noting that fixed offsets do not reconstruct every historical civil-time rule.
  • Preserve the allocation-conscious, ASCII case-insensitive, whole-trailing-token lookup implementation.
  • Add regression tests verifying canonical UTC instants for the supported abbreviations, including the CST and CDT corrections.

Validation

  • Focused date-parser tests: 156 passed
  • dotnet format VectorNNTPD.slnx --verify-no-changes: passed
  • Release x64 solution build and the full VectorNNTPD.Common.Tests suite passed before the final comment/documentation-only corrections; they were not rerun afterward.

Notes

The mappings are curated conventional offsets, not a complete historical timezone database. Ambiguous abbreviations are documented or intentionally excluded where a static mapping could produce misleading results. Numeric UTC±N table entries remain unchanged and are not recognized by the current trailing-letter matcher.

Fixes #164

Correct CST to the -06:00 North American news-date convention
and broaden the curated timezone table with international and
historical abbreviations. Document ambiguous mappings and
historical daylight offsets, and add UTC conversion tests.
@enteriaza enteriaza self-assigned this Oct 19, 2026
@enteriaza enteriaza added the bug Something isn't working label Oct 19, 2026
@enteriaza
enteriaza merged commit 219f425 into master Oct 19, 2026
7 checks passed
@enteriaza
enteriaza deleted the 164-bug-date-cst-is-parsed-as-0800-while-cdt-is-us-central branch October 19, 2026 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug: Date] CST is parsed as +08:00 while CDT is US Central

1 participant