Repository navigation
Conversation
Repost a consumed semaphore notification when another permit waiter remains, preventing an available permit from being stranded after cancellation. Add a deterministic regression test for the race.
Scope each cycle's CancellationTokenSource with using so it is disposed on exceptional exits while preserving gate-release ordering and deterministic regression-test cleanup.
enteriaza
deleted the
160-perf-allocation-article-work-parses-every-delivery-with-jsondocument
branch
October 19, 2026 16:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix a concurrency race in
NntpSessionPool.AcquirePermitAsyncwhere a cancelled waiter could consume the only available semaphore notification, leaving another waiter blocked indefinitely despite an available permit.Closes #161
Changes
finallyblock so test-hook exceptions cannot leave waiter accounting elevated.Cancelled_permit_wait_does_not_consume_the_only_wakeup, exercising the race across eight coordinated cycles and verifying that:Validation
NntpSessionPooltests: 52 passedOutstanding checks
Fixes #161