Repository navigation
Conversation
Keep the allocation-efficient stack-buffer path for ordinary request IDs and fall back to the original string validation for longer or segmented values. Add regression tests for extended valid GUID formats and long invalid inputs while preserving payload size limits and existing validation semantics.
Group version and Message-ID parsing state into private structs to eliminate excessive ref parameters while preserving existing validation and duplicate-property semantics.
enteriaza
deleted the
160-perf-allocation-article-work-parses-every-delivery-with-jsondocument
branch
October 19, 2026 15:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace
JsonDocument-based Article Work payload parsing withUtf8JsonReaderto reduce per-delivery allocations while preserving the existing validation and request identity semantics.Closes #160.
Changes
delivery.Body.Span, eliminating the per-deliveryJsonDocumentallocation.Testing and validation
Allocation comparison
A warmed Release-mode probe measured:
Utf8JsonReaderimplementationJsonDocumentcomparisonThis is a comparison against a reconstructed baseline, not a direct measurement of the deleted implementation. Rented document buffers are not included in the allocation count.
Notes
Fixes #160