Repository navigation
Conversation
Parse commands and Message-IDs directly from the pending buffer, and reuse per-session ARTICLE and DATE response buffers. Preserve command-buffer lifetime through handler completion and document the non-owning command memory contract.
enteriaza
deleted the
159-perf-allocation-cache-listener-copies-each-command-line-and-message-id-out-of-the-pending-buffer
branch
October 19, 2026 14:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reduces per-command allocations in
NntpCacheListenerSessionby parsing commands directly from the pending buffer and reusing per-session response buffers.Closes #159.
Changes
_pendinginstead of allocating a new array for every command line.220status lines into session-owned storage, avoiding a new array per ARTICLE command.111responses into a fixed-size, session-owned buffer._pending.CommandReadKind.Commandreferences the pending buffer and must not outlive its valid contents.The per-read
CancellationTokenSourceallocation inStreamCacheListenerTransportis unchanged.Testing and validation
--no-build)Notes
Fixes #159