Repository navigation
Fix release zips using backslashes in entry names (#492) - #502
Merged
Merged
Conversation
Compress-Archive in Windows PowerShell 5.1 (Microsoft.PowerShell.Archive 1.0.1.0) stores entries as plugins\Jotunn.dll. Since 7za.exe was replaced in 0951d15, the 2.30.1 and 2.30.2 Thunderstore zips have backslash paths, which unzip tools on Linux and macOS extract as flat files.
Moves the changelog line below the existing 2.30.3 entry.
Member
|
Thanks. I will note that the failed extraction is specific to the zip software used and not a universal issue. I tested the current zip with multiple Linux devices and all of them extracted the zip just fine. Still, using forward slashes is the of course more compatible. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #492.
The post-build step in JotunnLib.csproj runs
powershell.exe, so publish.ps1 always runs under Windows PowerShell 5.1, whoseCompress-Archivewrites\in zip entry names. The 2.30.1 and 2.30.2 Thunderstore packages haveplugins\Jotunn.dlland don't extract properly on Linux and macOS. Same problem as #191, which f7fa6f1 fixed by switching to 7za; 0951d15 went back toCompress-Archive.This replaces the two
Compress-Archivecalls with a small helper that zips through System.IO.Compression and writes/. If adding a file fails, the partial zip is deleted and the build fails. Before,Compress-Archivewrote the zip without that file and exited 0.Tested on Windows PowerShell 5.1 and pwsh 7.4 on Linux: entries come out as
plugins/Jotunn.dlland relative destination paths resolve correctly. On 5.1, a locked source file fails the build with no zip left behind. CI can't catch any of this since the post-build step only runs on Windows.