Repository navigation
Fix cumulative level effects on ragdolls without a character view - #496
Merged
MSchmoecker merged 1 commit intoOct 31, 2026
Merged
MSchmoecker merged 1 commit into
MSchmoecker merged 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A level-3 Seal ragdoll can run
LevelEffects.SetupLevelVisualizationwithout aCharacterorZNetView. If another mod has registered a custom creature, Jötunn's global cumulative-effects postfix dereferences that missing view and interrupts the Seal's death sequence. See #494.Change
Return from the cumulative-effects postfix when
LevelEffects, itsCharacter, or itsZNetViewis absent. Valid custom creatures keep the existing level-3+ behavior.Validation
Character.Damage.f4bb471: the original Seal ZDO remained after 15 seconds, and Unity logged aNullReferenceExceptioninCreatureManager.EnableCumulativeLevelEffectsfromCharacter.OnDeath.fac8bd4: the original Seal ZDO disappeared on the first post-damage census; the hosted-world test passed and the client quit cleanly. The Jötunn DLL was the only A/B change.Runner source and a build/run recipe are published separately (Program.cs, project file, README). The source contains no fixture, game binaries or private logs. The package-only example builds against Valheim.Testing.Game preview.15. The native A/B used the same scenario logic with a local project reference and two extra absent-plugin pins for station isolation; the public example omits those unrelated checks and has not been rerun in game. Reproducing the run requires a disposable Valheim 1.0.16 fixture and our pinned ValheimCLI fork, as detailed there.
This checks the reported Seal death/cleanup path. It does not assert loot distribution or every custom-creature death path.