[MidnightsFX]

I ran into an odd situation, where if for any reason mod code is loaded before a plugin has been initialized, its plugin signature will be cached as Jotunn.

This results in RPC names that include Jotunn as the plugin name, instead of the mods plugin name.

For example, static initialization of the localization manager in the plugins body, outside of awake, can result in registering the plugins RPCs under Jotunn.

internal class ModName: BaseUnityPlugin
{
   public static CustomLocalization Localization = LocalizationManager.Instance.GetLocalization();
  ...

Anything that walks through other mods and touches the plugin will load the static, which causes this issue- if the plugin itself is not already registered.

The trivial solution is not to call any manager instance instantiation in statics outside of the plugins awake. However, since this issue is otherwise transparent- having certain mod combinations installed could result in different RPC names on a server vs client.

[sirskunkalot]

Should that not be mitigated by having a dependency on Jötunn?

[MidnightsFX]

Should that not be mitigated by having a dependency on Jötunn?

It should if load order is observed. The problem, is if any mod loads others, classic example being caching asset packages etc. It can cause this.

I'm not saying this is absolutely required as a fix. But I noticed it after digging into a report and was trying to figure out how client vs server RPC registration did not match. It felt like something that would not be too hard to call out when it happens and would make diagnosing such issues considerably easier.

[sirskunkalot]

It does not really help that we have that static Localization in the mod stub I guess xD

[MidnightsFX]

Yeah that probably doesn't help 😅