Skip to content

build(deps): bump rust-payjoin from 14057c8 to 1c4130b - #261

Open
dependabot[bot] wants to merge 1 commit into
masterfrom
dependabot/submodules/rust-payjoin-1c4130b
Open

dependabot[bot] wants to merge 1 commit into
masterfrom
dependabot/submodules/rust-payjoin-1c4130b

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Nov 16, 2026

Copy link
Copy Markdown
Contributor

Bumps rust-payjoin from 14057c8 to 1c4130b.

Commits
  • 1c4130b Bump the github-actions group across 1 directory with 3 updates (#2053)
  • 9a5cd09 Bump the github-actions group across 1 directory with 3 updates
  • e1b3b28 Allow hooks 2 in the Dart bindings (#2052)
  • 6c39a08 Allow hooks 2 in the Dart bindings
  • 373645b Bindings release decouple (#2051)
  • d5a29df Skip the PyPI publish of the bindings for now
  • 3166260 Cut the bindings GitHub release from the build
  • dfe8864 Bump payjoin-ffi version to 0.26.0 (#2049)
  • 1850a4e Bump payjoin-ffi version to 0.26.0
  • 793a4e0 Nest TransactionParseError in FFI InputPairError (#2035)
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [rust-payjoin](https://github.com/payjoin/rust-payjoin) from `14057c8` to `1c4130b`.
- [Release notes](https://github.com/payjoin/rust-payjoin/releases)
- [Commits](payjoin/rust-payjoin@14057c8...1c4130b)

---
updated-dependencies:
- dependency-name: rust-payjoin
  dependency-version: 1c4130be6fa521906d2822c549b4a4061f5ccee6
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot Bot added dependencies Pull requests that update a dependency file submodules Pull requests that update submodules code labels Nov 16, 2026
@ValeraFinebits

Copy link
Copy Markdown
Owner

@chavic This upgrade raises an API question: how should the plugin classify payments first observed after session expiry and a restart, when replay_receiver_event_log rejects the expired session?

Would adding a small, read-only, serializable context from a finalized PayjoinProposal to Rust/FFI make sense? It could reuse the existing classifier without resuming negotiations. For our alpha, we only need new sessions, without legacy-log recovery.

Am I missing an existing supported approach, or does this seem like a reasonable minimal extension?

@chavic

chavic commented Nov 16, 2026

Copy link
Copy Markdown
Collaborator

You're not missing anything. On 1c4130b, classify_tx and classify_receiver_tx need a replayed session, and replay returns Expired for every session that isn't closed, Monitor included. Upstream knows: exempting posted sessions from expiry was tried in payjoin/rust-payjoin#1971 and deferred to the next major version (payjoin/rust-payjoin#1971 (comment)).

For the alpha I don't think we need a new FFI type. The plugin already saves ExpectedFinalTransactionId on the bridge when the proposal is finalized, and reconciliation uses that after expiry and a restart without the library. The only thing this bump takes away is ProposalTxidIsStable. Upstream removed it because it ignores receiver inputs, but we only contribute P2WPKH and Taproot inputs, so checking that the Original's inputs have empty scriptSigs (for example in ExtractTransactionFacts) gives the same guard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file submodules Pull requests that update submodules code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants