Skip to content

fix: Use Docker network for integration test nodes - #259

Merged
ValeraFinebits merged 3 commits into
masterfrom
fix/Use-Docker-network-for-integration-test-nodes
Nov 11, 2026
Merged

ValeraFinebits merged 3 commits into
masterfrom
fix/Use-Docker-network-for-integration-test-nodes

Conversation

@ValeraFinebits

@ValeraFinebits ValeraFinebits commented Nov 11, 2026 •

Copy link
Copy Markdown
Owner

Use Compose networking for test nodes, raise the inotify limit, and update System.Formats.Cbor to 9.0.24.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The unavailable BTCPay submodule Compose file leaves the expected Docker network and bitcoind port unconfirmed, with node synchronization still requiring integration validation.

No open issues 🎉

What changed in this PR

Updates integration-test node defaults to communicate over the Docker network rather than through the host.

Changes:

  • Sets the default Docker network to btcpayservertests_default.
  • Changes the primary node endpoint to bitcoind:39388, using Docker service-name resolution.
File Description
BTCPayServer.Plugins.Payjoin.IntegrationTests/​TestUtils/​BitcoindNodeOptions.cs Defaults test nodes to the Docker network and primary node’s service hostname.

Review effort: Balanced

@ValeraFinebits
ValeraFinebits marked this pull request as ready for review November 11, 2026 15:00
@ValeraFinebits
ValeraFinebits merged commit f18f80f into master Nov 11, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants