Repository navigation
fix: Use Docker network for integration test nodes - #259
Merged
ValeraFinebits merged 3 commits intoNov 11, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
The unavailable BTCPay submodule Compose file leaves the expected Docker network and bitcoind port unconfirmed, with node synchronization still requiring integration validation.
No open issues 🎉
What changed in this PR
Updates integration-test node defaults to communicate over the Docker network rather than through the host.
Changes:
- Sets the default Docker network to
btcpayservertests_default. - Changes the primary node endpoint to
bitcoind:39388, using Docker service-name resolution.
| File | Description |
|---|---|
BTCPayServer.Plugins.Payjoin.IntegrationTests/TestUtils/BitcoindNodeOptions.cs |
Defaults test nodes to the Docker network and primary node’s service hostname. |
Review effort: Balanced
ValeraFinebits
marked this pull request as ready for review
November 11, 2026 15:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use Compose networking for test nodes, raise the inotify limit, and update System.Formats.Cbor to 9.0.24.