fix(bin): enforce ship brief decision and pipeline contracts - #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent
Fix four demonstrated gaps in the ordinary ship brief generated by bin/fm-brief.sh, with regression tests through the script executable interface. Decision provenance: a worker must describe a decision as coming from firstmate unless firstmate explicitly says the captain made it; standing yolo authority must never be rewritten as a direct captain decision. Nonterminal statuses: the generated contract must cover every nonterminal line, explicitly including resolved:, require the same turn to continue, and after responding to a no-mistakes gate the worker must wait for the next pipeline return rather than ending its turn. Completion boundary: in no-mistakes mode an implementation commit is a working: milestone, never done:; done: is reserved for the existing PR-with-green-checks terminal condition. Distinguishable evidence: when a task requires evidence from multiple execution paths, copied or byte-identical artifacts are insufficient; each artifact must visibly prove which path produced it. Inspect existing brief tests and history before choosing wording. Extend the smallest existing tests through fm-brief.sh output and behavior; tests must not assert implementation-source bytes. Review the complete branch diff after all lint and test fixes. Preserve commits c37dead and 2bea96a exactly. Run fresh no-mistakes validation and delivery on this clean head, push fm/brief-autorstvi-rozhodnuti, open a PR against fork main, drive every synchronous return through checks-passed or passed, never merge, and report the full PR URL. Do not add Herdr lifecycle commands.
What Changed
done:for PRs with green checks, usingworking:for committed implementation milestones, with executable-interface regression coverage.Risk Assessment
✅ Low: The change is narrowly scoped to the generated ordinary ship brief, satisfies the source-verifiable intent across all delivery modes, and tests the emitted brief through the script executable interface without introducing material risk.
Testing
Reviewed the scoped diff and history, ran the focused executable-interface brief tests, and manually generated and inspected the actual worker-facing no-mistakes brief; all required provenance, nonterminal continuation, pipeline-return, completion-boundary, and distinguishable-evidence contracts rendered correctly. No screenshot was produced because the end-user surface is generated Markdown, preserved directly as the evidence artifact.
Evidence: Generated no-mistakes ordinary ship brief
Source: Generated no-mistakes ordinary ship brief
Pipeline
Updates from git push no-mistakes
✅ **intent** - passed
✅ No issues found.
✅ **Rebase** - passed
✅ No issues found.
✅ **Review** - passed
✅ No issues found.
✅ **Test** - passed
✅ No issues found.
Inspectedgit diff 2d475fa3ffe21726dc2f6e3b004e381c17b0033d..HEAD -- bin/fm-brief.sh tests/fm-brief.test.shand recent branch history.Rantests/fm-brief.test.sh.Generated an ordinary ship brief throughFM_HOME=<evidence-home> bin/fm-brief.sh evidence-ordinary-ship demo-project --mode no-mistakes.Inspected the generated public brief contract withrg -n -C 3 "Definition of done|Delivery contract|implementation milestone|States:|Every status|Describe each decision|multiple execution paths|no-mistakes axi respond|After /no-mistakes reports" <generated-brief>.Rangit status --shortafter testing to confirm no worktree artifacts remained.✅ **Document** - passed
✅ No issues found.
✅ **Lint** - passed
✅ No issues found.
✅ **Push** - passed
✅ No issues found.