Make the "Edit data" chart link translatable - #1246
Merged
Merged
Conversation
The link under the 24 hour and monthly energy plots was hardcoded English, so it had no token on Localazy for translators to pick up. Add dashboard.edit_data to the English source and look it up in DayPlot/MonthPlot, falling back to "Edit data". Refs #1197 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
🔧 PR Build ArtifactsVersion: All environments built successfully. Download the zip files:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reported by @zarhan in #1197: there is no Localazy token for Edit data.
The link under the 24 hour and monthly energy plots was hardcoded English in
DayPlot.svelte/MonthPlot.svelte, so it never made it intolocalazy/source/en.jsonand translators had nothing to translate.Changes
localazy/source/en.json— newdashboard.edit_datatokenui/src/lib/DayPlot.svelte,ui/src/lib/MonthPlot.svelte— subscribe totranslationsStoreand usetranslations.dashboard?.edit_data ?? 'Edit data', same pattern asUptime.svelte/Header.svelteui/dist/index.js— rebuilt (npm run build), as in previous commits touching the UIAfter merge the token needs pushing to Localazy (
cd localazy && localazy upload ...) before translators can see it.Verified
cd ui && npm run buildsucceeds (only the pre-existing a11y warnings), and the built bundle contains the new lookup with its English fallback.Not included
PricePlot.sveltehas the same problem with"Provided by: "— left alone to keep this PR to the reported string.🤖 Generated with Claude Code