Add managed Agent Skills - #2091
Open
KoenLemmen wants to merge 1 commit into
Open
KoenLemmen wants to merge 1 commit into
KoenLemmen wants to merge 1 commit into
Conversation
KoenLemmen
force-pushed
the
codex/managed-skills-core
branch
from
September 21, 2026 23:23
e4b35e3 to
a583dcc
Compare
Author
|
CI note: Cloud shards |
KoenLemmen
marked this pull request as ready for review
September 21, 2026 23:51
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add managed Agent Skills
Summary
This PR is a successor to Rhys Sullivan's Agent Skills work in #1986. It keeps the owner-scoped skill model, GitHub import, console management, MCP delivery, and native agent sync. It adds immutable package revisions, source update review, toolkit membership, dependency reporting, and code-execution delivery.
disable-model-invocationas the initial delivery preference.truekeeps a skill out of automatic discovery.falseor an omitted field allows model selection. The Executor switch can override either value.skillstool instead of renaming the built-in guide tool. Existing calls such asskills({ name: "execute" })keep working. Model-enabled managed skills appear in discovery, while manual skills remain available by exact name or reference.SKILL.mdloads without frontmatter and points to bundled files,fileremains an alias forpath, andskill://<owner>/<name>/<path>remains available beside Executor's stable ID-based resources.Compared with #1986, this change uses immutable revisions, staged multi-skill imports, source update review, toolkit membership, dependency diagnostics, explicit delivery state, code-execution delivery, and the existing
skillsMCP contract.Linked issue
Successor to #1986.
Verification
bun run format:checkbun run lintbun run typecheck -- --concurrency=1(45 packages)bun run check:routes(5 generated trees)TURBO_TEST_CONCURRENCY=1 bun run test(39 tasks)cd e2e && ../node_modules/.bin/vitest run --project selfhost scenarios/managed-skills.test.ts(2 scenarios)The focused self-host run records the
disable-model-invocationpreference, the model-selection override, dependency display, immediate list refresh, the toolkit empty state, and immediate toolkit availability. It also verifies MCP discovery, frontmatter-free instruction loading, bundled-file indexing, and thefilealias. Each scenario includes screenshots, a video, and a Playwright trace.Screenshots
GitHub import finds 38 skills in
mattpocock/skills. Users can install selected skills or the complete repository.The Skills page shows installed packages, ownership, and invocation state.
Users can edit the files in an imported package. Saving creates a new revision.
Workspace toolkits can limit which managed skills their agents discover.
A source preference can disable automatic model selection. The Executor switch can override that preference after confirmation.
Watch the GitHub import recording (trimmed and slowed for review).
Checklist