Report the Cloudflare Access principal on /account/members - #2089
Open
ian-pascoe wants to merge 1 commit into
Open
ian-pascoe wants to merge 1 commit into
ian-pascoe wants to merge 1 commit into
Conversation
The console infers workspace-admin from that list, so an empty response locked edit/delete even when ADMIN_EMAILS granted admin.
Contributor
|
hey @ian-pascoe i previously had a PR #2022 that fixes #1958, which seems to be highly related to your change here. feel free to have a look #2022 |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Cloudflare host always returned an empty
/account/memberslist. The console infers workspace-admin from that list (isCurrentUser+ role), soADMIN_EMAILSnever unlocked edit/delete.listMembersnow returns the current Access principal.Linked issue
Fixes #2045
Verification
cd apps/host-cloudflare && bun run test src/account/account-provider.test.ts— 2 passedoxfmt --checkon the two filesbun run format:checkbun run lintbun run typecheckbun run testChecklist
@executor-js/host-cloudflareis private and not changeset-managed