Let users cancel and retry OAuth sign-in - #2070
Draft
RhysSullivan wants to merge 2 commits into
Draft
RhysSullivan wants to merge 2 commits into
RhysSullivan wants to merge 2 commits into
Conversation
Contributor
Cloudflare preview
Sign-in is Cloudflare Access (one-time PIN to an allowed email). The preview has its own database and encryption key; it is destroyed when this PR closes. |
@executor-js/cli
@executor-js/config
@executor-js/execution
@executor-js/sdk
@executor-js/codemode-core
@executor-js/runtime-quickjs
@executor-js/plugin-file-secrets
@executor-js/plugin-graphql
@executor-js/plugin-keychain
@executor-js/plugin-mcp
@executor-js/plugin-onepassword
@executor-js/plugin-openapi
executor
commit: |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
executor-marketing | 2fbc1fb | Commit Preview URL Branch Preview URL |
Sep 18 2026, 09:47 PM |
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
executor-cloud | 2fbc1fb | Sep 18 2026, 09:48 PM |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closing the provider window can leave Add connection stuck on a disabled Connecting button. Keep the connection form visible and replace the waiting button with an enabled Cancel sign-in action. Close stays available. Cancel immediately restores Connect.
Keep each OAuth attempt's response separate so a delayed response cannot reopen a cancelled flow or cancel a newer session.
Validation: three focused browser scenarios pass, including consent after both interruption and an overlapping retry. They also assert that the existing form stays visible during sign-in. The same interrupted-flow test fails on main. 80 focused unit checks, React/E2E types, and scoped lint pass. Provider checks use the published Slack emulator.
A separate MCP origin-drift check completed reconnect but failed its final health assertion after discovery timed out locally. CI is still running.