Default the Add connection tab to OAuth when a matching app exists - #2066
Merged
Merged
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
executor-marketing | b549288 | Commit Preview URL Branch Preview URL |
Sep 18 2026, 07:58 PM |
Contributor
Cloudflare previewTorn down — the PR is closed. |
@executor-js/cli
@executor-js/config
@executor-js/execution
@executor-js/sdk
@executor-js/codemode-core
@executor-js/runtime-quickjs
@executor-js/plugin-file-secrets
@executor-js/plugin-graphql
@executor-js/plugin-keychain
@executor-js/plugin-mcp
@executor-js/plugin-onepassword
@executor-js/plugin-openapi
executor
commit: |
RhysSullivan
force-pushed
the
fix/connection-oauth-default
branch
from
September 18, 2026 19:57
1ee663a to
b549288
Compare
RhysSullivan
changed the title
RhysSullivan
marked this pull request as ready for review
September 18, 2026 20:00
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
executor-cloud | b549288 | Sep 18 2026, 08:00 PM |
RhysSullivan
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an integration offers both an API key and OAuth, select OAuth only when a matching client is available. Use the app picker’s integration, endpoint and scope rules. Otherwise keep the API-key default. Late client responses preserve the user’s selected method and any key already entered.
Verified: 87 focused unit tests, all 6 connection scenarios on cloud and self-host, React and E2E type checks, lint, and formatting pass. Chrome also checked ready-client and missing-client forms. Provider consent uses the published Slack emulator. All 43 CI checks pass; one check is skipped.
The change: which tab opens first
Both columns use the same OpenAPI test setup: an API-key method, an OAuth method, and an already-registered OAuth app. Neither opening excerpt clicks an auth tab. Before, API key is selected. After, OAuth is selected automatically.
The comparison crops the first 2.5 seconds of each original recording, then holds the final frame. Labels and outlines identify the selected tabs.
Full original recordings
No matching client: keep the API-key default
Late client response: preserve the entered key
All recordings use synthetic accounts. Filming adds deliberate pauses; video duration is not a page-load measurement.