Protect deployment database connections - #2057
Merged
Merged
Conversation
Contributor
Cloudflare previewTorn down — the PR is closed. |
@executor-js/cli
@executor-js/config
@executor-js/execution
@executor-js/sdk
@executor-js/codemode-core
@executor-js/runtime-quickjs
@executor-js/plugin-file-secrets
@executor-js/plugin-graphql
@executor-js/plugin-keychain
@executor-js/plugin-mcp
@executor-js/plugin-onepassword
@executor-js/plugin-openapi
executor
commit: |
RhysSullivan
marked this pull request as ready for review
September 18, 2026 18:52
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
executor-marketing | 66a82a1 | Commit Preview URL Branch Preview URL |
Sep 18 2026, 06:59 PM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deployment scripts currently stop as soon as PostgreSQL refuses a connection with SQLSTATE
53300. Add a bounded connection preflight to migrations and the membership-readiness gate. Retry admission only; migration bodies and readiness mutations still run once. Reject PlanetScale pooler URLs for these session-sensitive scripts.Add a five-minute Actions capacity check that fails below ten ordinary free connections, and document the hard PgBouncer budget, direct deployment route, and safe cutover procedure. Scheduled checks use existing Actions failure notifications and become active after merge.
Validation: focused connection tests, real PostgreSQL 18 recovery followed by all schema migrations, and an isolated PgBouncer test with 32 clients capped at 12 backends while direct migration access remained available. Prepared statements passed across backend reassignment. Format, lint, typecheck, and the full Test job passed in CI. Workflow validation passed locally. All CI checks passed on the updated head. The existing cap-eviction E2E scenario timed out on earlier attempts with Durable Object concurrency resets while its test database remained healthy; it passed on a fresh CI runner (3.7 seconds), standalone locally, and in the full local shard (39 tests). The timeout cause remains unresolved. No E2E assertions or runtime behavior were changed.