Skip to content

Show disabled integration actions for members - #2051

Merged
RhysSullivan merged 2 commits into
mainfrom
fix/integration-admin-ui
Sep 18, 2026
Merged

RhysSullivan merged 2 commits into
mainfrom
fix/integration-admin-ui

Conversation

@RhysSullivan

@RhysSullivan RhysSullivan commented Sep 18, 2026

Copy link
Copy Markdown
Collaborator

Summary

Members could open integration creation flows even though the server rejected their writes. Keep restricted integration actions visible and disabled across the page header, empty state, sidebar, command palette, catalog, and Edit/Delete controls. Disabled controls explain that a workspace admin is required.

Members can browse the catalog, view existing integrations, and open personal connection setup. Catalog Add buttons, URL submission (including Enter), and setup shortcuts are disabled. Direct setup links explain the admin requirement. Admin creation and single-user access stay available.

Verification

  • bun run format:check
  • bun run lint
  • bun run typecheck — 45 tasks passed.
  • cd packages/react && bun run test — 49 files, 446 tests passed.
  • Cloud and self-host integration-creation-permissions.test.ts — both passed. Each creates an integration through the admin UI and verifies persisted state. Member checks cover visible disabled controls, the hover/focus explanation, command-palette entries, Edit/Delete, catalog Add buttons, URL submission, personal connection setup, and direct setup links.
  • Full unit suite passed in CI on this PR head (run).

Evidence

The member recording and screenshots show visible disabled controls, the admin tooltip, catalog browsing, and disabled Edit/Delete. All identities and integrations are synthetic.

Integration creation · self-host members see admin guidance and owners can add (selfhost)

00-member-sees-disabled-creation-controls-with-an-admin-explana.png

04-member-browses-the-catalog-with-disabled-add-buttons.png

02-member-sees-disabled-edit-and-delete-actions.png

Checklist

  • Added a changeset.
  • Added browser regression scenarios for cloud and self-host.
  • No secrets, credentials, or private data in the diff.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Sep 18, 2026

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
executor-marketing 15e75a6 Commit Preview URL

Branch Preview URL
Sep 18 2026, 06:38 PM

@github-actions

github-actions Bot commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

Cloudflare preview

Torn down — the PR is closed.

@pkg-pr-new

pkg-pr-new Bot commented Sep 18, 2026

Copy link
Copy Markdown

Open in StackBlitz

@executor-js/cli

npm i https://pkg.pr.new/@executor-js/cli@2051

@executor-js/config

npm i https://pkg.pr.new/@executor-js/config@2051

@executor-js/execution

npm i https://pkg.pr.new/@executor-js/execution@2051

@executor-js/sdk

npm i https://pkg.pr.new/@executor-js/sdk@2051

@executor-js/codemode-core

npm i https://pkg.pr.new/@executor-js/codemode-core@2051

@executor-js/runtime-quickjs

npm i https://pkg.pr.new/@executor-js/runtime-quickjs@2051

@executor-js/plugin-file-secrets

npm i https://pkg.pr.new/@executor-js/plugin-file-secrets@2051

@executor-js/plugin-graphql

npm i https://pkg.pr.new/@executor-js/plugin-graphql@2051

@executor-js/plugin-keychain

npm i https://pkg.pr.new/@executor-js/plugin-keychain@2051

@executor-js/plugin-mcp

npm i https://pkg.pr.new/@executor-js/plugin-mcp@2051

@executor-js/plugin-onepassword

npm i https://pkg.pr.new/@executor-js/plugin-onepassword@2051

@executor-js/plugin-openapi

npm i https://pkg.pr.new/@executor-js/plugin-openapi@2051

executor

npm i https://pkg.pr.new/executor@2051

commit: 15e75a6

@RhysSullivan RhysSullivan changed the title Align integration creation UI with admin permissions Show disabled integration actions for members Sep 18, 2026
@RhysSullivan
RhysSullivan marked this pull request as ready for review September 18, 2026 18:44
@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
✅ Deployment successful!
View logs
executor-cloud 15e75a6 Sep 18 2026, 06:39 PM

@RhysSullivan
RhysSullivan merged commit 31b24b8 into main Sep 18, 2026
78 of 80 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant