Skip to content

Accept Slack bot and user OAuth grants - #2050

Merged
RhysSullivan merged 2 commits into
mainfrom
fix/connection-slack-grants
Sep 18, 2026
Merged

RhysSullivan merged 2 commits into
mainfrom
fix/connection-slack-grants

Conversation

@RhysSullivan

@RhysSullivan RhysSullivan commented Sep 18, 2026

Copy link
Copy Markdown
Collaborator

Summary

Slack sign-in can return HTTP 200 but fail to save a connection because Slack uses bot and user token types. Normalize successful Slack grants, including nested user grants, for code exchange and refresh while retaining token validation.

Verification

  • The Slack emulator browser scenario fails before the fix and passes on this isolated branch.
  • SDK OAuth tests: 96 passed, covering exchange and refresh, mixed bot/user grants, preservation of standard bearer responses, and rejection of unsupported token types.
  • SDK and E2E type checks, scoped lint, and formatting passed.

Response formats were checked against Slack’s OAuth documentation and token rotation guide. Live Slack bot and user-only consent saved connections on this PR preview. Both grants passed authenticated identity calls and two successive token refreshes, including reuse of the rotated refresh token. Refresh was triggered by advancing only each disposable connection's stored expiry; requests and responses used real Slack endpoints. All current PR checks passed after rerunning a transient OpenAPI timeout failure. Live account evidence remains private.

Recordings

Synthetic test accounts only. The before recording ends after the error appears; the test then fails while waiting for a saved connection.

Before

slack-sign-in-before.mp4

After

slack-sign-in-after.mp4

@github-actions

github-actions Bot commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

Cloudflare preview

Torn down — the PR is closed.

@pkg-pr-new

pkg-pr-new Bot commented Sep 18, 2026

Copy link
Copy Markdown

Open in StackBlitz

@executor-js/cli

npm i https://pkg.pr.new/@executor-js/cli@2050

@executor-js/config

npm i https://pkg.pr.new/@executor-js/config@2050

@executor-js/execution

npm i https://pkg.pr.new/@executor-js/execution@2050

@executor-js/sdk

npm i https://pkg.pr.new/@executor-js/sdk@2050

@executor-js/codemode-core

npm i https://pkg.pr.new/@executor-js/codemode-core@2050

@executor-js/runtime-quickjs

npm i https://pkg.pr.new/@executor-js/runtime-quickjs@2050

@executor-js/plugin-file-secrets

npm i https://pkg.pr.new/@executor-js/plugin-file-secrets@2050

@executor-js/plugin-graphql

npm i https://pkg.pr.new/@executor-js/plugin-graphql@2050

@executor-js/plugin-keychain

npm i https://pkg.pr.new/@executor-js/plugin-keychain@2050

@executor-js/plugin-mcp

npm i https://pkg.pr.new/@executor-js/plugin-mcp@2050

@executor-js/plugin-onepassword

npm i https://pkg.pr.new/@executor-js/plugin-onepassword@2050

@executor-js/plugin-openapi

npm i https://pkg.pr.new/@executor-js/plugin-openapi@2050

executor

npm i https://pkg.pr.new/executor@2050

commit: 0732f9c

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Sep 18, 2026

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
✅ Deployment successful!
View logs
executor-cloud 0732f9c Sep 18 2026, 06:40 PM

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Sep 18, 2026

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
executor-marketing 0732f9c Commit Preview URL

Branch Preview URL
Sep 18 2026, 06:40 PM

@RhysSullivan
RhysSullivan marked this pull request as ready for review September 18, 2026 19:23
@RhysSullivan
RhysSullivan merged commit 24adb12 into main Sep 18, 2026
79 of 80 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant