Accept Slack bot and user OAuth grants - #2050
Merged
Merged
Conversation
Contributor
Cloudflare previewTorn down — the PR is closed. |
@executor-js/cli
@executor-js/config
@executor-js/execution
@executor-js/sdk
@executor-js/codemode-core
@executor-js/runtime-quickjs
@executor-js/plugin-file-secrets
@executor-js/plugin-graphql
@executor-js/plugin-keychain
@executor-js/plugin-mcp
@executor-js/plugin-onepassword
@executor-js/plugin-openapi
executor
commit: |
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
executor-cloud | 0732f9c | Sep 18 2026, 06:40 PM |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
executor-marketing | 0732f9c | Commit Preview URL Branch Preview URL |
Sep 18 2026, 06:40 PM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Slack sign-in can return HTTP 200 but fail to save a connection because Slack uses
botandusertoken types. Normalize successful Slack grants, including nested user grants, for code exchange and refresh while retaining token validation.Verification
Response formats were checked against Slack’s OAuth documentation and token rotation guide. Live Slack bot and user-only consent saved connections on this PR preview. Both grants passed authenticated identity calls and two successive token refreshes, including reuse of the rotated refresh token. Refresh was triggered by advancing only each disposable connection's stored expiry; requests and responses used real Slack endpoints. All current PR checks passed after rerunning a transient OpenAPI timeout failure. Live account evidence remains private.
Recordings
Synthetic test accounts only. The before recording ends after the error appears; the test then fails while waiting for a saved connection.
Before
slack-sign-in-before.mp4
After
slack-sign-in-after.mp4