Fix macOS auto-update: preserve framework symlinks in the update zip - #2049
Merged
Merged
Conversation
Contributor
Cloudflare previewTorn down — the PR is closed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every Mac on 1.6.8 sees "Restart to update" for 1.6.9 do nothing.
The 1.6.9 mac zip was built with electron-builder 26.15.0, which swapped its bundled 7-Zip 16.02 for 7-Zip 24.09. The new 7za dereferences symlinks by default, so the framework
Versions/Current -> Alinks were expanded into copies (zip went from 200 MB to 421 MB, zero symlink entries). The extracted app failscodesign --verifywith "bundle format is ambiguous", Squirrel.Mac rejects it, andquitAndInstallbecomes a no-op. The DMG is unaffected. Upstream fixed this in later 26.15.x by passing-snl.codesign --verify --deep --strict.before-quit-for-update(after Squirrel has accepted the bundle), and surface a rejected install as "Update failed" instead of leaving the card unchanged.Ships as a desktop patch release so 1.6.8 and 1.6.9 installs pick up a valid zip.