Skip to content

Add a self-host opt-out for Better Auth rate limiting - #2044

Merged
RhysSullivan merged 1 commit into
mainfrom
selfhost-auth-rate-limit
Sep 18, 2026
Merged

RhysSullivan merged 1 commit into
mainfrom
selfhost-auth-rate-limit

Conversation

@RhysSullivan

Copy link
Copy Markdown
Collaborator

The v1.6.9 self-host Docker publish failed its e2e gate: every sign-in from the harness got HTTP 429. Better Auth 1.6.17 and later (v1.6.9 ships 1.6.22, v1.6.8 shipped 1.6.12) enforce sign-in rate limits strictly in production. The image runs with NODE_ENV=production, and with no trusted proxy header Better Auth pools every caller into one bucket of three sign-ins per ten seconds. The suite signs in from 100+ test files at once. The dev-server e2e in CI never saw this because rate limiting is off outside production.

  • EXECUTOR_DISABLE_AUTH_RATE_LIMIT=true turns Better Auth's limiter off. Default stays on. Only an explicit opt-out is passed to Better Auth, so the production/development default is untouched otherwise.
  • The Docker e2e boot sets the flag for the container it tests.
  • Documented in the Docker page and .env.example. Config test covers the exact-string opt-in.
  • Patch changeset on executor so the release cuts v1.6.10 and re-runs the Docker publish.

Follow-up worth a separate issue: a self-host exposed without a proxy header shares one sign-in bucket across all users. Better Auth's advanced.ipAddress options (ipAddressHeaders, trustedProxies) should be operator-configurable.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Sep 18, 2026 •

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
executor-marketing 64b3c13 Commit Preview URL

Branch Preview URL
Sep 18 2026, 11:26 AM

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Sep 18, 2026 •

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
✅ Deployment successful!
View logs
executor-cloud 64b3c13 Sep 18 2026, 11:27 AM

@RhysSullivan
RhysSullivan marked this pull request as ready for review September 18, 2026 11:26
@github-actions

github-actions Bot commented Sep 18, 2026 •

Copy link
Copy Markdown
Contributor

Cloudflare preview

Torn down — the PR is closed.

@pkg-pr-new

pkg-pr-new Bot commented Sep 18, 2026

Copy link
Copy Markdown

Open in StackBlitz

@executor-js/cli

npm i https://pkg.pr.new/@executor-js/cli@2044

@executor-js/config

npm i https://pkg.pr.new/@executor-js/config@2044

@executor-js/execution

npm i https://pkg.pr.new/@executor-js/execution@2044

@executor-js/sdk

npm i https://pkg.pr.new/@executor-js/sdk@2044

@executor-js/codemode-core

npm i https://pkg.pr.new/@executor-js/codemode-core@2044

@executor-js/runtime-quickjs

npm i https://pkg.pr.new/@executor-js/runtime-quickjs@2044

@executor-js/plugin-file-secrets

npm i https://pkg.pr.new/@executor-js/plugin-file-secrets@2044

@executor-js/plugin-graphql

npm i https://pkg.pr.new/@executor-js/plugin-graphql@2044

@executor-js/plugin-keychain

npm i https://pkg.pr.new/@executor-js/plugin-keychain@2044

@executor-js/plugin-mcp

npm i https://pkg.pr.new/@executor-js/plugin-mcp@2044

@executor-js/plugin-onepassword

npm i https://pkg.pr.new/@executor-js/plugin-onepassword@2044

@executor-js/plugin-openapi

npm i https://pkg.pr.new/@executor-js/plugin-openapi@2044

executor

npm i https://pkg.pr.new/executor@2044

commit: 64b3c13

@RhysSullivan
RhysSullivan merged commit 004024b into main Sep 18, 2026
44 checks passed
@RhysSullivan RhysSullivan mentioned this pull request Sep 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant