Add a self-host opt-out for Better Auth rate limiting - #2044
Merged
Merged
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
executor-marketing | 64b3c13 | Commit Preview URL Branch Preview URL |
Sep 18 2026, 11:26 AM |
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
executor-cloud | 64b3c13 | Sep 18 2026, 11:27 AM |
RhysSullivan
marked this pull request as ready for review
September 18, 2026 11:26
Contributor
Cloudflare previewTorn down — the PR is closed. |
@executor-js/cli
@executor-js/config
@executor-js/execution
@executor-js/sdk
@executor-js/codemode-core
@executor-js/runtime-quickjs
@executor-js/plugin-file-secrets
@executor-js/plugin-graphql
@executor-js/plugin-keychain
@executor-js/plugin-mcp
@executor-js/plugin-onepassword
@executor-js/plugin-openapi
executor
commit: |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The v1.6.9 self-host Docker publish failed its e2e gate: every sign-in from the harness got HTTP 429. Better Auth 1.6.17 and later (v1.6.9 ships 1.6.22, v1.6.8 shipped 1.6.12) enforce sign-in rate limits strictly in production. The image runs with
NODE_ENV=production, and with no trusted proxy header Better Auth pools every caller into one bucket of three sign-ins per ten seconds. The suite signs in from 100+ test files at once. The dev-server e2e in CI never saw this because rate limiting is off outside production.EXECUTOR_DISABLE_AUTH_RATE_LIMIT=trueturns Better Auth's limiter off. Default stays on. Only an explicit opt-out is passed to Better Auth, so the production/development default is untouched otherwise..env.example. Config test covers the exact-string opt-in.executorso the release cuts v1.6.10 and re-runs the Docker publish.Follow-up worth a separate issue: a self-host exposed without a proxy header shares one sign-in bucket across all users. Better Auth's
advanced.ipAddressoptions (ipAddressHeaders,trustedProxies) should be operator-configurable.