Skip to content

Hide integration Edit/Delete controls for non-admin members #2013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RhysSullivan merged 1 commit into from
Sep 15, 2026
Merged

Hide integration Edit/Delete controls for non-admin members #2013

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 18 additions & 5 deletions packages/react/src/pages/integration-detail.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ import { IntegrationEditSheet } from "../components/metadata-edit-sheet";
import { Tabs, TabsContent, TabsList, TabsTrigger } from "../components/tabs";
import { authMethodsFromDescriptors, type AuthMethod } from "../lib/auth-placements";
import { usePolicyActions } from "../hooks/use-policy-actions";
import { useCanCreateWorkspaceConnections } from "../multiplayer/use-admin-nav";
import { useIntegrationPlugins, type IntegrationAccountHandoff } from "@executor-js/sdk/client";
import { Button } from "../components/button";
import { Skeleton } from "../components/skeleton";
Expand Down Expand Up @@ -84,9 +85,13 @@ export function IntegrationDetailPage(props: {
const connectionsResult = useAtomValue(connectionsAllAtom);
const refreshIntegrations = useAtomRefresh(integrationsOptimisticAtom);
const refreshTools = useAtomRefresh(integrationToolsAllAtom(slug));
const doRemove = useAtomSet(removeIntegrationOptimistic, { mode: "promiseExit" });
const doRemove = useAtomSet(removeIntegrationOptimistic, {
mode: "promiseExit",
});
const doRefresh = useAtomSet(refreshConnection, { mode: "promiseExit" });
const doCheckHealth = useAtomSet(checkConnectionHealth, { mode: "promiseExit" });
const doCheckHealth = useAtomSet(checkConnectionHealth, {
mode: "promiseExit",
});
// Policies are owner-partitioned on write; the integration policy menu writes
// Workspace (org) rules, preserving the prior default behavior.
const policyActions = usePolicyActions("org");
Expand Down Expand Up @@ -133,8 +138,12 @@ export function IntegrationDetailPage(props: {
useExecutorDocumentTitle(integrationData?.name || namespace);
const isBuiltInIntegration = namespace === "executor" || integrationData?.kind === "built-in";
const currentTab = isBuiltInIntegration ? "tools" : activeTab;
// Integrations are workspace-owned; the server refuses catalog mutations
// (update/remove) from non-admin members, so hide the controls for them.
const canMutateIntegration = useCanCreateWorkspaceConnections();
const canEdit = canMutateIntegration && !isBuiltInIntegration && integrationData !== null;
const canRefresh = integrationData?.canRefresh ?? false;
const canRemove = integrationData?.canRemove ?? false;
const canRemove = canMutateIntegration && (integrationData?.canRemove ?? false);
const urlAccountHandoff = useMemo<IntegrationAccountHandoff | null>(() => {
const search = new URLSearchParams(locationSearch);
// The route-validated flag and the raw `addAccount=1` are the same request;
Expand Down Expand Up @@ -389,7 +398,11 @@ export function IntegrationDetailPage(props: {
if (connection.integration !== slug) continue;
connectionCount++;
const refreshExit = await doRefresh({
params: { owner: connection.owner, integration: slug, name: connection.name },
params: {
owner: connection.owner,
integration: slug,
name: connection.name,
},
reactivityKeys: connectionWriteKeys,
});
refreshExits.push(Exit.isSuccess(refreshExit));
Expand Down Expand Up @@ -485,7 +498,7 @@ export function IntegrationDetailPage(props: {
</div>

<div className="flex shrink-0 items-center gap-2">
{!confirmDelete && !isBuiltInIntegration && integrationData && (
{!confirmDelete && canEdit && (
<Button variant="outline" size="sm" onClick={() => setEditSheetOpen(true)}>
Edit
</Button>
Expand Down
Loading