Improve Capture Video window by todi1856 · Pull Request #229 · Unity-Technologies/com.unity.mobile.logcat

todi1856 · 2026-10-22T19:09:34Z

Purpose of PR

Type of change: Improvement to Video Capture

https://jira.unity3d.com/browse/PLAT-23512

Screen recordings in the Screen Capture window are now made from the live stream, and can be played back in the window.

https://www.youtube.com/watch?v=exqVXgTFjNU&feature=youtu.be

Highlights

Recording from the live stream
- The live view's JPEG frames are encoded straight to MP4 with UnityEditor.Media.MediaEncoder, replacing adb screenrecord.
- Output is constant frame rate (H.264 Baseline), at the live stream's Max Frame Rate, now capped at 60.
- A still screen is still recorded: the last frame is repeated as time passes.
- Follows the live view's rotation.
- Decoding and encoding run within a time budget on each Editor update, so the Editor stays responsive.
- A red REC timer shows over the live view while recording.
Recording time limit in Preferences (default 10 minutes, max 60). A recording also stops and is saved when the stream ends, the device changes, or scripts reload.
Square Video in Preferences (on by default): the video is a square of the stream's longest side, so turning the device or unfolding a foldable keeps the picture at full size. On foldables the other screen's size is read from dumpsys display.
Record Touches in Preferences (on by default): clicks and drags sent from the live view are saved with the recording, and drawn as coloured markers during playback (Android does not draw injected touches itself).
Per-frame metadata in the recording's .json, as frameChanges over time:
- the device's display size, shown in the details column at the current playback time;
- where the picture sits in the video, so playback crops out the black areas;
- the recorded touches. Built to take logcat messages later.
Video player for recordings in the capture list:
- opens paused;
- play/pause, a time slider (dragging pauses and resumes, like YouTube) and frame step back/forward;
- Frame Rate shown in the details column, which stays put while the picture changes shape.
- Built around an explicit state machine, with a state history in Developer Mode.
Capture list
- Disabled while recording.
- A finished recording flashes in the list like a screenshot instead of being selected.
- Rename and delete work on recordings too.
Domain reload
- The window keeps its selection, the video position, and the zoom of both views.
- The live stream's cleanup no longer hangs the "Reloading Domain" dialog.
Zoom badge has a right-click menu with fixed zoom levels (100%–4000%), and is easier to read.
Profiler markers (AndroidLogcat.*) for the recording and live stream hot paths.

Halo effect

Screen Capture window: live view, capture list, screenshots. adb screenrecord is no longer used. Linux has no H.264 encoder or player, so recording and playback are unavailable there, and the video tests are skipped.

Testing status

New AndroidLogcatVideoPlayerTests. Test videos are generated at test time with MediaEncoder. They cover opening, play/pause, stepping, seeking while paused and while playing, resuming, single-frame videos, and rename/delete of the previewed recording.
New AndroidLogcatStreamRecorderTests: frame changes of frames still queued keep their time after a later touch.
Integration tests record from the live stream (CanRecordTheLiveStream, RecordingNeedsTheLiveStream).
Tested manually on Windows with Android devices, including high resolution and 60 fps streams.

🤖 Generated with Claude Code

u-pr

💡 Harness Review

The change unifies screenshots and recordings in the live capture workflow, but the recording lifecycle and shared file operations need corrections.

Renaming a recording changes its extension to .png, so the capture preview can no longer play it. The newly listed recordings use RenameScreenshot, which constructs the destination with GetImageExtension() rather than preserving the source extension. SyncPreview then sends the renamed MP4 bytes to Texture2D.LoadImage because IsVideo returns false. Construct the destination with Path.GetExtension(path). Use that extension in the collision message.

_{Reviewed commit 01c3eef}

_{🤖 Helpful? 👍/👎}

A screenrecord capture with a variable frame rate and a single keyframe, which AndroidLogcatVideoPlayerTests play, step and seek through. Marked binary in .gitattributes, which otherwise normalizes every file as text. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

todi1856 · 2026-10-23T17:10:50Z

/review

u-pr

💡 Harness Review

Recordings now share the capture list and gain an interactive preview, but the new playback and storage paths still have correctness gaps.

_{Reviewed commit 9d58996}

_{🤖 Helpful? 👍/👎}

todi1856 · 2026-10-30T12:43:01Z

/review

u-pr

💡 Harness Review

The change integrates live-stream recording and video previews into the capture list, but encoder failures can leave the interface displaying an active recording that is no longer producing frames.

_{Reviewed commit 1090ca4}

_{🤖 Helpful? 👍/👎}

todi1856 · 2026-10-30T13:14:38Z

/review

u-pr

💡 Harness Review

The change replaces device-side video capture with live-stream recording and integrates playback into the capture list. I examined recording lifecycle, frame timing, preview controls, file operations, and reload restoration, and found no new actionable issues beyond those previously reported.

_{Reviewed commit e2cef57}

_{⚠️ Earlier blocking findings with unresolved threads: 2. The rating above does not cover them; resolve each thread after addressing it. Earlier blocking summary findings: 1. The rating above does not cover them; after addressing each one, hide the review that posted it.}

_{🤖 Helpful? 👍/👎}

todi1856 · 2026-10-30T14:48:27Z

/review

u-pr

💡 Harness Review

The change integrates live-stream recording with capture-list playback, with a correctness issue in the new recording metadata timeline.

_{Reviewed commit cc42acf}

_{🤖 Helpful? 👍/👎}

u-pr · 2026-10-30T14:51:42Z

+            if (last != null && last.time >= time)
+                return last;


When a rotated frame is decoded after a later touch is logged, playback crops the rotated frame using the previous content rectangle. The recorder’s update budget allows queued frames to remain while live-view input logs touches. NoteTouch timestamps changes using NowUs, while Decode timestamps metadata using the frame’s recording slot. ChangeAt returns the latest entry for any earlier timestamp, so NoteContent can move a queued frame’s crop change to the later touch time. Display-size changes are delayed similarly. Insert changes in timestamp order. Merge entries only when their timestamps match.

_{🤖 Helpful? 👍/👎}

todi1856 · 2026-10-30T14:56:43Z

/review

u-pr

💡 Harness Review

The change replaces device-side recording with live-stream encoding and adds playback controls and selection restoration. I examined recording timing, preview behavior, capture operations, and lifecycle handling, and found no new issues beyond those previously reported.

_{Reviewed commit af3a26e}

_{⚠️ Earlier blocking findings with unresolved threads: 1. The rating above does not cover them; resolve each thread after addressing it. Earlier blocking summary findings: 1. The rating above does not cover them; after addressing each one, hide the review that posted it.}

_{🤖 Helpful? 👍/👎}

todi1856 added 2 commits September 29, 2026 12:12

WIP: recording

1e3329b

Merge remote-tracking branch 'origin/master' into livestream-video

01c3eef

u-pr Bot reviewed Oct 22, 2026

View reviewed changes

todi1856 and others added 16 commits October 23, 2026 18:59

apply review fixes

9d4f02d

try making seek

e39845f

fix seeking while paused

9438fa1

fix play after seeking

147a375

remove length

0bea531

don't start automatically

0dd55f1

use state changing

5aa696c

add seeking by 1 frame

a5b3cc7

still try to make see work

5690249

tests

5ef7377

fix tests

0b8b944

split logic

627b507

clear button

2a870c9

fix seeking

86cb58d

Use different name for video tests

9d58996

todi1856 added 2 commits October 23, 2026 20:11

remove

54b9034

delete

abb254d

u-pr Bot reviewed Oct 23, 2026

View reviewed changes

Comment thread com.unity.mobile.android-logcat/Editor/AndroidLogcatCaptureScreenshot.cs Resolved

Comment thread com.unity.mobile.android-logcat/Editor/AndroidLogcatCaptureList.cs Resolved

Comment thread com.unity.mobile.android-logcat/Editor/AndroidLogcatVideoInformation.cs Resolved

todi1856 added 7 commits October 26, 2026 17:19

remove m_PreviewIsVideo

ff9ef31

Flash video instead of switching to it

f042fc8

disable capture list while video is being taken

46ed651

Consolidate into AllocateCapturePath

adaf11f

docs

56c2e18

improve drag

266f247

apply review

05efe53

todi1856 added 2 commits October 30, 2026 14:37

Preserve video/screenshot selection after domain reload

e2e050f

Fix being stuck on domain reload

1090ca4

u-pr Bot reviewed Oct 30, 2026

View reviewed changes

Comment thread com.unity.mobile.android-logcat/Editor/AndroidLogcatCaptureVideo.cs Resolved

todi1856 added 5 commits October 30, 2026 14:52

apply review

e9da491

apply fixes

62463fe

restore zoom after domain reload

e9f84ae

restore zoom for live view after domain reload

e301374

Add context menu for zoom badge

e2cef57

make badge more visible

e407608

u-pr Bot reviewed Oct 30, 2026

View reviewed changes

todi1856 added 6 commits October 30, 2026 15:33

respect device rotation when recording

6fd7192

Add ability to capture squared videos

63b06b9

record display changes

547e27d

Clip video, respect display & content

54638bd

better tooltip for square video

9148ea1

add record touches functionality

cc42acf

u-pr Bot reviewed Oct 30, 2026

View reviewed changes

todi1856 added 2 commits October 30, 2026 16:51

use different colors for touch actions

8386b10

apply fix with test

af3a26e

u-pr Bot reviewed Oct 30, 2026

View reviewed changes

todi1856 added 3 commits October 30, 2026 17:07

reformat

0ca3b08

fixate width for details ui

502ef21

update docs

294f36a

todi1856 changed the title ~~Livestream video~~ Improve Capture Video window Oct 30, 2026

todi1856 requested review from a team and BorisShir October 30, 2026 15:24

Conversation

todi1856 commented Oct 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Purpose of PR

Highlights

Halo effect

Testing status

Uh oh!

u-pr Bot left a comment

Choose a reason for hiding this comment

💡 Harness Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

todi1856 commented Oct 23, 2026

Uh oh!

u-pr Bot left a comment

Choose a reason for hiding this comment

💡 Harness Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

todi1856 commented Oct 30, 2026

Uh oh!

u-pr Bot left a comment

Choose a reason for hiding this comment

💡 Harness Review

Uh oh!

Uh oh!

todi1856 commented Oct 30, 2026

Uh oh!

u-pr Bot left a comment

Choose a reason for hiding this comment

💡 Harness Review

Uh oh!

todi1856 commented Oct 30, 2026

Uh oh!

u-pr Bot left a comment

Choose a reason for hiding this comment

💡 Harness Review

Uh oh!

u-pr Bot Oct 30, 2026

Choose a reason for hiding this comment

Uh oh!

todi1856 commented Oct 30, 2026

Uh oh!

u-pr Bot left a comment

Choose a reason for hiding this comment

💡 Harness Review

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

todi1856 commented Oct 22, 2026 •

edited

Loading