build(deps): bump @biomejs/biome to 2.5.3#273
Merged
Conversation
Biome 2.5.3 promotes noUnsafeOptionalChaining and noSvgWithoutTitle to errors. Six test assertions used `x?.y as T` around a value they then dereferenced — replace with a plain destructure + cast so the type asserts the presence Biome now requires. Add a <title> to public/icon.svg.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@biomejs/biomefrom 2.4.16 to 2.5.3 (the piece that was carved out of build(deps): bump the patch-and-minor group with 23 updates #270 / build(deps): bump the patch-and-minor group across 1 directory with 22 updates #272 via@dependabot ignore).lint/correctness/noUnsafeOptionalChainingin three test files where mock-call args were cast withx?.y as Tand then dereferenced. Reworked asconst [call] = mock.calls[0]plus a single cast, so the type asserts the presence Biome now requires without adding runtime checks.lint/a11y/noSvgWithoutTitleinpublic/icon.svg— added a<title>Unitae</title>element.Once this merges, Biome will still be pinned in Dependabot config from the earlier
@dependabot ignore @biomejs/biome minor versionon #270 — no action needed unless we want future minor bumps proposed automatically, in which case comment@dependabot unignore @biomejs/biomeon any Dependabot PR.Test plan