Add Xquik OpenAPI parser coverage#2
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 71bf9b02f8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @@ -0,0 +1,97 @@ | |||
| import { describe, expect, it } from "vitest"; | |||
There was a problem hiding this comment.
Keep Vitest tests out of the server build
Because this test is placed under src/generator, it matches tsconfig.server.json's src/generator/**/* include and will be emitted by npm run build:server into dist/server/generator/ApiParser.test.js with a test-only vitest import. In deploy or publish contexts that consume the server build artifact without devDependencies, this leaves a production artifact that can fail if loaded or packaged; move the test under an excluded test location or exclude *.test.ts from the server tsconfig.
Useful? React with 👍 / 👎.
|
If this is useful and you merge it after checks pass, feel free to share the PR on X/Twitter and mention my handle, burakbayir. I can repost or retweet it to my 24k followers of developers and power users, which may help more relevant users discover this repo. |
Summary:
Validation: