Skip to content

Add Xquik OpenAPI parser coverage#2

Open
kriptoburak wants to merge 1 commit into
UnitOneAI:mainfrom
kriptoburak:codex/xquik-openapi-parser-test
Open

Add Xquik OpenAPI parser coverage#2
kriptoburak wants to merge 1 commit into
UnitOneAI:mainfrom
kriptoburak:codex/xquik-openapi-parser-test

Conversation

@kriptoburak

Copy link
Copy Markdown

Summary:

  • Add an OpenAPI 3.1 parser regression case using the public Xquik search endpoint shape.
  • Cover API-key auth detection, server extraction, operation IDs, and query parameters.

Validation:

  • npx vitest run --root . src/generator/ApiParser.test.ts

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 71bf9b02f8

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@@ -0,0 +1,97 @@
import { describe, expect, it } from "vitest";

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Keep Vitest tests out of the server build

Because this test is placed under src/generator, it matches tsconfig.server.json's src/generator/**/* include and will be emitted by npm run build:server into dist/server/generator/ApiParser.test.js with a test-only vitest import. In deploy or publish contexts that consume the server build artifact without devDependencies, this leaves a production artifact that can fail if loaded or packaged; move the test under an excluded test location or exclude *.test.ts from the server tsconfig.

Useful? React with 👍 / 👎.

@kriptoburak

Copy link
Copy Markdown
Author

If this is useful and you merge it after checks pass, feel free to share the PR on X/Twitter and mention my handle, burakbayir. I can repost or retweet it to my 24k followers of developers and power users, which may help more relevant users discover this repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant