Add local options to save source and destination in project#2415
Open
luizzeroxis wants to merge 3 commits into
Open
Add local options to save source and destination in project#2415luizzeroxis wants to merge 3 commits into
luizzeroxis wants to merge 3 commits into
Conversation
|
Download the artifacts for this pull request here: GUI:
CLI: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a new project-local.json file to the project directory. It stores the source and destination files used by the project, making it so you don't need to specify them every time you load a project. This file and its options should not be committed to version control, since it contains your own local paths.
Caveats
I'm not sure if the structure I did in the code is correct, it feels a bit shoehorned in. Also the new local options class uses PathPair from the main one, so that should probably be moved as well.
Notes
I'm not sure if this should create a .gitignore since we don't initialize git anyway.