Skip to content

fix(apollo-react): make in-progress execution spinner info-colored [MST-12191]#916

Merged
BenNormann merged 4 commits into
mainfrom
fix/mst-12191-in-progress-spinner-color
Jul 17, 2026
Merged

fix(apollo-react): make in-progress execution spinner info-colored [MST-12191]#916
BenNormann merged 4 commits into
mainfrom
fix/mst-12191-in-progress-spinner-color

Conversation

@BenNormann

@BenNormann BenNormann commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Summary

The InProgress branch of ExecutionStatusIcon rendered apollo-wind's Spinner without applying the var(--color-info-icon) it already computes, so running stage nodes and task rows showed apollo-wind's default muted-grey spinner (text-muted-foreground) — barely visible on the canvas. This applies the info color, bringing in-progress in line with every other execution status. Fixes COX feedback that the in-progress indicator is hardly visible (MST-12191).

Demo

image image image image

... cont.

Changes

  • ExecutionStatusIcon.tsx — color the InProgress spinner via className="[&>svg]:text-[color:var(--color-info-icon)]". Spinner forwards className only to its outer <div> and hardcodes text-muted-foreground on the inner Loader2, so a descendant-svg override is needed; it wins on specificity (0,1,1 > 0,1,0). Same [&>svg]: pattern already used in BaseNodeInnerShape.tsx.
  • ExecutionStatusIcon.test.tsx — the Spinner mock now forwards className; added a test asserting the InProgress spinner carries the info color.

Flow

flowchart TD
    A[status = InProgress] --> B["getExecutionStatusColor()<br/>= var(--color-info-icon)"]
    B --> C{InProgress branch}
    C -->|before: color dropped| D["Spinner default<br/>text-muted-foreground (grey)"]
    C -->|after: color applied| E["[&>svg]:text-[color:var(--color-info-icon)]<br/>overrides muted grey"]
Loading

E2E Impact

N/A — apollo-ui component-library change. Verified visually in Storybook (ExecutionStatusIcon story): the In Progress spinner now renders info-blue, matching the other statuses.

Testing

  • vitest run ExecutionStatusIcon — 3/3 pass
  • biome check — clean
  • tsc --noEmit — 0 errors
  • Manual: Storybook ExecutionStatusIcon / StageNode stories
  • Type-safe (no as any / suppressions added)

Notes

This fix lives in @uipath/apollo-react. It needs a release and a dependency bump in PO.Frontend before it reaches the product; no PO.Frontend source change is required.

Copilot AI review requested due to automatic review settings July 15, 2026 23:19
@github-actions

github-actions Bot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (PT)
apollo-design 🟢 Ready Preview, Logs Jul 17, 2026, 10:19:25 AM
apollo-docs 🟢 Ready Preview, Logs Jul 17, 2026, 10:19:25 AM
apollo-landing 🟢 Ready Preview, Logs Jul 17, 2026, 10:19:25 AM
apollo-vertex 🟢 Ready Preview, Logs Jul 17, 2026, 10:19:25 AM

@github-actions

Copy link
Copy Markdown
Contributor

Dependency License Review

  • 1950 package(s) scanned
  • ✅ No license issues found
  • ⚠️ 2 package(s) excluded (see details below)
License distribution
License Packages
MIT 1720
ISC 89
Apache-2.0 55
BSD-3-Clause 27
BSD-2-Clause 23
BlueOak-1.0.0 8
MPL-2.0 4
MIT-0 3
CC0-1.0 3
MIT OR Apache-2.0 2
(MIT OR Apache-2.0) 2
Unlicense 2
LGPL-3.0-or-later 1
Python-2.0 1
CC-BY-4.0 1
(MPL-2.0 OR Apache-2.0) 1
Unknown 1
Artistic-2.0 1
(WTFPL OR MIT) 1
(BSD-2-Clause OR MIT OR Apache-2.0) 1
CC-BY-3.0 1
0BSD 1
(MIT OR CC0-1.0) 1
MIT AND ISC 1
Excluded packages
Package Version License Reason
@img/sharp-libvips-linux-x64 1.2.4 LGPL-3.0-or-later LGPL pre-built binary, not linked
khroma 2.1.0 Unknown MIT per GitHub repo, missing license field in package.json

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a visibility issue in @uipath/apollo-react’s canvas execution status indicator by ensuring the InProgress state spinner is rendered using the info icon color instead of apollo-wind’s default muted spinner color.

Changes:

  • Apply an info-color override to the Spinner’s inner SVG for the InProgress execution status.
  • Update the Spinner test mock to forward className/style and add a unit test asserting the info-color override class is present.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
packages/apollo-react/src/canvas/components/ExecutionStatusIcon/ExecutionStatusIcon.tsx Forces the InProgress spinner’s inner SVG to render with --color-info-icon for better visibility.
packages/apollo-react/src/canvas/components/ExecutionStatusIcon/ExecutionStatusIcon.test.tsx Enhances the Spinner mock and adds a test to prevent regressions in InProgress spinner coloring.

@github-actions

github-actions Bot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

📊 Coverage + size by package

Per-package coverage and bundle size on this PR. New-line coverage = of the source lines this PR adds or changes, the % hit by tests.

Package Coverage New-line coverage Packed (gzip) Unpacked vs main
@uipath/apollo-core 9.0% 43.82 MB 57.31 MB ±0
@uipath/apollo-react 37.2% 91.9% (373/406) 7.38 MB 28.15 MB +376 B
@uipath/apollo-wind 40.3% 395.1 KB 2.57 MB +8 B
@uipath/ap-chat 85.8% 43.43 MB 55.92 MB ±0

"Coverage" is each package's own coverage.include scope (e.g. apollo-core instruments only scripts/). "Packed"/"Unpacked" come from npm pack --dry-run and only cover built packages — "—" means not measured this run (package not affected / not built). "vs main" is the packed (gzipped) delta against the last successful main build (the package-sizes artifact from the Release workflow); "—" there means no main baseline was available this run. The baseline is main's latest build, not this PR's exact merge-base, so it includes any drift since the branch diverged. Packages with no vitest config are omitted.

Copilot AI review requested due to automatic review settings July 15, 2026 23:32

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

Copilot AI review requested due to automatic review settings July 16, 2026 17:16
@BenNormann
BenNormann force-pushed the fix/mst-12191-in-progress-spinner-color branch from 1aa1963 to 7ad94cf Compare July 16, 2026 17:16

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

Copilot AI review requested due to automatic review settings July 17, 2026 00:46

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

Copilot AI review requested due to automatic review settings July 17, 2026 17:13
@github-actions github-actions Bot added size:M 30-99 changed lines. and removed size:S 10-29 changed lines. labels Jul 17, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

@BenNormann
BenNormann merged commit 5afe047 into main Jul 17, 2026
44 checks passed
@BenNormann
BenNormann deleted the fix/mst-12191-in-progress-spinner-color branch July 17, 2026 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg:apollo-react size:M 30-99 changed lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants