You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The InProgress branch of ExecutionStatusIcon rendered apollo-wind's Spinner without applying the var(--color-info-icon) it already computes, so running stage nodes and task rows showed apollo-wind's default muted-grey spinner (text-muted-foreground) — barely visible on the canvas. This applies the info color, bringing in-progress in line with every other execution status. Fixes COX feedback that the in-progress indicator is hardly visible (MST-12191).
Demo
... cont.
Changes
ExecutionStatusIcon.tsx — color the InProgress spinner via className="[&>svg]:text-[color:var(--color-info-icon)]". Spinner forwards className only to its outer <div> and hardcodes text-muted-foreground on the inner Loader2, so a descendant-svg override is needed; it wins on specificity (0,1,1 > 0,1,0). Same [&>svg]: pattern already used in BaseNodeInnerShape.tsx.
ExecutionStatusIcon.test.tsx — the Spinner mock now forwards className; added a test asserting the InProgress spinner carries the info color.
Flow
flowchart TD
A[status = InProgress] --> B["getExecutionStatusColor()<br/>= var(--color-info-icon)"]
B --> C{InProgress branch}
C -->|before: color dropped| D["Spinner default<br/>text-muted-foreground (grey)"]
C -->|after: color applied| E["[&>svg]:text-[color:var(--color-info-icon)]<br/>overrides muted grey"]
Loading
E2E Impact
N/A — apollo-ui component-library change. Verified visually in Storybook (ExecutionStatusIcon story): the In Progress spinner now renders info-blue, matching the other statuses.
This fix lives in @uipath/apollo-react. It needs a release and a dependency bump in PO.Frontend before it reaches the product; no PO.Frontend source change is required.
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR fixes a visibility issue in @uipath/apollo-react’s canvas execution status indicator by ensuring the InProgress state spinner is rendered using the info icon color instead of apollo-wind’s default muted spinner color.
Changes:
Apply an info-color override to the Spinner’s inner SVG for the InProgress execution status.
Update the Spinner test mock to forward className/style and add a unit test asserting the info-color override class is present.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
Per-package coverage and bundle size on this PR. New-line coverage = of the source lines this PR adds or changes, the % hit by tests.
Package
Coverage
New-line coverage
Packed (gzip)
Unpacked
vs main
@uipath/apollo-core
9.0%
—
43.82 MB
57.31 MB
±0
@uipath/apollo-react
37.2%
91.9% (373/406)
7.38 MB
28.15 MB
+376 B
@uipath/apollo-wind
40.3%
—
395.1 KB
2.57 MB
+8 B
@uipath/ap-chat
85.8%
—
43.43 MB
55.92 MB
±0
"Coverage" is each package's own coverage.include scope (e.g. apollo-core instruments only scripts/). "Packed"/"Unpacked" come from npm pack --dry-run and only cover built packages — "—" means not measured this run (package not affected / not built). "vs main" is the packed (gzipped) delta against the last successful main build (the package-sizes artifact from the Release workflow); "—" there means no main baseline was available this run. The baseline is main's latest build, not this PR's exact merge-base, so it includes any drift since the branch diverged. Packages with no vitest config are omitted.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
InProgressbranch ofExecutionStatusIconrendered apollo-wind'sSpinnerwithout applying thevar(--color-info-icon)it already computes, so running stage nodes and task rows showed apollo-wind's default muted-grey spinner (text-muted-foreground) — barely visible on the canvas. This applies the info color, bringing in-progress in line with every other execution status. Fixes COX feedback that the in-progress indicator is hardly visible (MST-12191).Demo
... cont.
Changes
ExecutionStatusIcon.tsx— color the InProgress spinner viaclassName="[&>svg]:text-[color:var(--color-info-icon)]".SpinnerforwardsclassNameonly to its outer<div>and hardcodestext-muted-foregroundon the innerLoader2, so a descendant-svg override is needed; it wins on specificity (0,1,1 > 0,1,0). Same[&>svg]:pattern already used inBaseNodeInnerShape.tsx.ExecutionStatusIcon.test.tsx— theSpinnermock now forwardsclassName; added a test asserting the InProgress spinner carries the info color.Flow
flowchart TD A[status = InProgress] --> B["getExecutionStatusColor()<br/>= var(--color-info-icon)"] B --> C{InProgress branch} C -->|before: color dropped| D["Spinner default<br/>text-muted-foreground (grey)"] C -->|after: color applied| E["[&>svg]:text-[color:var(--color-info-icon)]<br/>overrides muted grey"]E2E Impact
N/A — apollo-ui component-library change. Verified visually in Storybook (
ExecutionStatusIconstory): the In Progress spinner now renders info-blue, matching the other statuses.Testing
vitest run ExecutionStatusIcon— 3/3 passbiome check— cleantsc --noEmit— 0 errorsExecutionStatusIcon/StageNodestoriesas any/ suppressions added)Notes
This fix lives in
@uipath/apollo-react. It needs a release and a dependency bump in PO.Frontend before it reaches the product; no PO.Frontend source change is required.