Repository navigation
Add btc send endpoints - #9
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add BTC send and witness receive endpoints
Changes
POST /wallet/sendbtcbeginwith{address, amount, fee_rate}returns{psbt}.POST /wallet/sendbtcendwith{signed_psbt}broadcasts and returns{txid}.POST /wallet/witnessreceivetakes the same body as/wallet/blindreceiveand returnsthe same
ReceiveData. Recipient ids look likebcrt:wvout:…, and the sender funds theoutput via
witness_data.amount_sat.ReceiveKind(Blind/Witness) and calls rgb-lib'sblind_receiveorwitness_receive.RgbWalletState::blind_receive_tokenis renamedto
receive_token.the new paths plus
SendBtcBeginRequestModelandSendBtcResponse.Existing routes and response shapes are unchanged.
Notes for review
fee_rateonsendbtcbeginhas no default. All threefields are required.
sendbtcenduses the sharedPsbtrequest struct, so it also accepts the legacysignedPsbtspelling. The spec documents onlysigned_psbt.