Repository navigation
Conversation
…f 500 When the wallet id was absent or unknown, the loop logged and continued without answering the oneshot, so send_cmd reported 'wallet thread is dead' (HTTP 500) - indistinguishable from a dead server and an invitation to retry-storm. Reply InvalidFingerprint (HTTP 400, the id is the master fingerprint) on every variant via an exhaustive helper.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the wallet id was absent or the wallet unknown (dropped/evicted), the loop logged and
continued without answering the oneshot, sosend_cmdreportedwallet thread is dead(HTTP 500) — indistinguishable from a dead server and an invitation to retry-storm it.Adds an exhaustive
respond_wallet_missinghelper replyingInvalidFingerprint(the id is the master fingerprint; maps to HTTP 400 via the existing classifier) on all 32 command variants. Drop/Stop keep their existing arms and semantics.Verified by exhaustive variant cross-check against the enum +
rustfmtparse. Fullcargo testcould not run here (privatergb-*-s-bfadeps need repo access) — requesting CI.