Repository navigation
Conversation
drop() evicted by bare master fingerprint alone, skipping the derive_wctx() re-register + validation every other endpoint performs. Anyone presenting a 4-byte fingerprint could evict someone else's in-memory wallet, forcing full re-register + resync and breaking in-flight begin/end flows. Route drop through derive_wctx like the rest.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every endpoint routes through
derive_wctx()(re-register + validate the xpub pair against the fingerprint) — exceptdrop, which evicted by bare 4-byte master fingerprint alone. Anyone presenting a fingerprint could evict someone else's in-memory wallet, forcing a full re-register + resync and breaking in-flight begin/end flows.One-hunk fix: route
dropthroughderive_wctxlike the rest. Pattern is identical to neighboring endpoints;rustfmt --checkclean on the hunk. Fullcargo testcould not run here (privatergb-*-s-bfadeps need repo access) — requesting CI.