Skip to content

fix(logger): skip Slack POST when webhook URL is empty #4956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
droplet-rl wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(logger): skip Slack POST when webhook URL is empty #4956

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/logger/src/logger/SlackTransport.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,6 +187,11 @@ class SlackHook extends Transport {
// different slack channels depending on the context of the log.
const webhookUrl = this.escalationPathWebhookUrls[info.notificationPath] ?? this.defaultWebHookUrl;

// An empty (or unset) webhook URL means this notification path has been intentionally disabled in the config.
// Drop the message silently rather than POSTing to an empty URL, which would otherwise surface as a transport
// error and escalate to PagerDuty.
if (!webhookUrl) return callback();

const payload: { blocks?: Block[]; text?: string; mrkdwn?: boolean } = { mrkdwn: this.mrkdwn };
const layout = this.formatter(info);
payload.blocks = layout.blocks || undefined;
Expand Down