Conversation
The known-limitations note claimed the library falls back to SD card capture when streaming fails on the A2500. It does not: shoot(stream=True) goes to _shoot_streaming and raises, and nothing calls _shoot_standard after it. A caller reading that line would plan for a fallback that was never written.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The known-limitations note said the library falls back to SD card capture when streaming fails on the A2500. It does not.
shoot(stream=True)goes to_shoot_streamingand raises; nothing calls_shoot_standardafter it.A caller reading that line would plan for a fallback that was never written — which is how it surfaced: Captua's CHDK backend captures with
stream=Trueon the strength of it, and a review of that backend asked why it had no fallback path.The note now says what is true: streaming may fail with PTP
0x2002, it raises, and a caller that wants the picture anyway has to callshoot()itself and collect it from the card. It also says that whether the A2500 fails this way in practice has not been established against hardware — the cameras have not been run yet.