Repository navigation
fix(ci): deploy the docs from a single Pages workflow - #305
Merged
Merged
Conversation
deploy-prebuilt-site.yml triggered on docs/site/**, a subset of the docs/** path deploy-docs.yml already renders and deploys, and both ran into the same pages concurrency group with cancel-in-progress off, so the last one to finish overwrote the other. Keep the rendering workflow. Closes NEH-147
There was a problem hiding this comment.
🟢 Approval recommended
The remaining workflow covers documentation changes, rendering, manual dispatch, and Pages deployment without duplication.
Pull request overview
Removes the redundant Pages deployment workflow so documentation deploys only through the rendering workflow.
Changes:
- Deletes the overlapping pre-built documentation deployment workflow.
- Prevents competing deployments to the shared
pagesconcurrency group.
File summaries
| File | Description |
|---|---|
.github/workflows/deploy-prebuilt-site.yml |
Removes the duplicate Pages deployment workflow. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
deploy-prebuilt-site.ymltriggered ondocs/site/**, a subset of thedocs/**path thatdeploy-docs.ymlalready renders and deploys, and both ran into the samepagesconcurrency group with cancel-in-progress off, so whichever finished last won. Keep the rendering workflow only. Nothing else referenced the deleted one.Closes NEH-147