Skip to content

BMS DBC files and BMS dashboard#168

Open
Cdella778 wants to merge 2 commits into
mainfrom
dbc-update-bms
Open

BMS DBC files and BMS dashboard#168
Cdella778 wants to merge 2 commits into
mainfrom
dbc-update-bms

Conversation

@Cdella778

@Cdella778 Cdella778 commented Jul 4, 2026

Copy link
Copy Markdown

Sunlink Pull Request Description

Monday Link

Effected Components

  • Link Telemetry
  • Parser
  • Influx
  • Grafana
  • DBC
  • Sunlink environment
  • Tools
  • Tests
  • Docs

Testing

  • Vehicle testing
  • Randomizer testing
  • Other
  • N/A

Sanity check

  • CAN ID table / DBC updated
  • gitignore updated and commited
  • Steps confirmed

Sources

@Cdella778 Cdella778 requested a review from AarjavJain101 July 4, 2026 23:31
AarjavJain101
AarjavJain101 previously approved these changes Jul 6, 2026

@AarjavJain101 AarjavJain101 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs changes

Comment thread dbc/brightside.dbc Outdated
@AarjavJain101 AarjavJain101 self-requested a review July 6, 2026 01:20
@AarjavJain101 AarjavJain101 dismissed their stale review July 6, 2026 01:21

Lookign for changes.

@AarjavJain101 AarjavJain101 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes needed.

Comment thread dbc/cascadia.dbc

BU_: AMB BMS ECU TEL OBC MEMORATOR MDI MC STR DRD MPPT DIST MST

BO_ 770 HvcHeartbeat: 2 HVC

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upper case HVC and MST in the names. Makes it easy to read. They are acronyms after all.

Comment thread dbc/cascadia.dbc

BS_:

BU_: AMB BMS ECU TEL OBC MEMORATOR MDI MC STR DRD MPPT DIST MST

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add HVC

Comment thread dbc/cascadia.dbc

BU_: AMB BMS ECU TEL OBC MEMORATOR MDI MC STR DRD MPPT DIST MST

BO_ 770 HvcHeartbeat: 2 HVC

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Follow same naming conventions as all the other messages. That is TimeSinceBootUp.

Comment thread dbc/cascadia.dbc
Comment on lines +55 to +56
BO_ 773 HvcShuntCurrent: 4 HVC
SG_ ShuntCurrent : 7|32@0- (1,0) [-2147483648|2147483647] "mA" Vector__XXX

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Name the signal name to "PackCurrent". The message name can stay the same. This is because when STG or EMD are looking at the data and they see ShuntCurrent its not clear what that means. We have used Pack Current in the past as well so that familiarity sticks.

Comment thread dbc/cascadia.dbc
Comment on lines +58 to +59
BO_ 774 DistHeartBeat: 3 DIST
SG_ DistHeartbeat : 0|1@1+ (1,0) [0|1] "" Vector__XXX

@AarjavJain101 AarjavJain101 Jul 6, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use All caps for DIST.

Comment thread dbc/cascadia.dbc
Comment on lines +90 to +91
SG_ ScrutineeringEnable : 45|1@1+ (1,0) [0|1] "" Vector__XXX
BO_ 785 VoltSummary: 6 MST

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a new line. Keep the same formatting as what was in the file before.

Comment thread dbc/cascadia.dbc
Comment on lines +180 to +194
SG_ Mod11Status m2 : 32|8@1+ (1,0) [0|255] "" Vector__XXX
SG_ Mod12Status m3 : 8|8@1+ (1,0) [0|255] "" Vector__XXX
SG_ Mod13Status m3 : 16|8@1+ (1,0) [0|255] "" Vector__XXX
SG_ Mod14Status m3 : 24|8@1+ (1,0) [0|255] "" Vector__XXX
SG_ Mod15Status m3 : 32|8@1+ (1,0) [0|255] "" Vector__XXX
SG_ Mod16Status m4 : 8|8@1+ (1,0) [0|255] "" Vector__XXX
SG_ Mod17Status m4 : 16|8@1+ (1,0) [0|255] "" Vector__XXX
SG_ Mod18Status m4 : 24|8@1+ (1,0) [0|255] "" Vector__XXX
SG_ Mod19Status m4 : 32|8@1+ (1,0) [0|255] "" Vector__XXX
SG_ Mod20Status m5 : 8|8@1+ (1,0) [0|255] "" Vector__XXX
SG_ Mod21Status m5 : 16|8@1+ (1,0) [0|255] "" Vector__XXX
SG_ Mod22Status m5 : 24|8@1+ (1,0) [0|255] "" Vector__XXX
SG_ Mod23Status m5 : 32|8@1+ (1,0) [0|255] "" Vector__XXX
SG_ Mod24Status m6 : 8|8@1+ (1,0) [0|255] "" Vector__XXX
SG_ Mod25Status m6 : 16|8@1+ (1,0) [0|255] "" Vector__XXX

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you confirm that this DBC file is what we used during our Saturday integration test? I want to make sure that the multiplexing is working.

Can you also give a brief reply as to why the voltage reading's were inaccurate on Grafana on Saturday? Is the fix for that in the DBC or in FW? This dictates whether this PR needs more changing or not.

Comment thread dbc/cascadia.dbc
Comment on lines +99 to +100
BO_ 787 ModuleVoltData: 5 MST
SG_ VoltGroupIdx M : 0|4@1+ (1,0) [0|15] "" Vector__XXX

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Voltage is more clear and easier read to me.

Comment thread dbc/cascadia.dbc
SG_ Mod31Temp m7 : 32|8@1- (1,0) [-127|127] "degC" Vector__XXX
BO_ 789 ModuleStatus: 8 MST
SG_ StatusGroupIdx M : 0|3@1+ (1,0) [0|7] "" Vector__XXX
SG_ Mod0Status m0 : 8|8@1+ (1,0) [0|255] "" Vector__XXX

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Status of what about a module? This name is a bit ambiguous.

@AarjavJain101 AarjavJain101 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more changes.

Comment thread dbc/cascadia.dbc
BU_: AMB BMS ECU TEL OBC MEMORATOR MDI MC STR DRD MPPT DIST MST

BO_ 770 HvcHeartbeat: 2 HVC
SG_ HvcHeartbeatCounter : 7|16@0+ (1,0) [0|65535] "" Vector__XXX

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make this 32 bits. Standardized. All TimeSinceBootUp messages should follow the same standard for ease and organization in the future.

Comment thread dbc/cascadia.dbc
SG_ ShuntCurrent : 7|32@0- (1,0) [-2147483648|2147483647] "mA" Vector__XXX

BO_ 774 DistHeartBeat: 3 DIST
SG_ DistHeartbeat : 0|1@1+ (1,0) [0|1] "" Vector__XXX

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should also be 32 bits. A heartbeat is a counter.

Comment thread dbc/cascadia.dbc
SG_ SpareCurrent : 32|8@1+ (5,0) [0|1275] "mA" Vector__XXX

BO_ 784 BmsStatus: 8 MST
SG_ BmsHeartbeatCounter : 0|32@1+ (1,0) [0|4294967295] "" Vector__XXX

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MST heartbeat counter. BMSStatus is ok because it is the status of our BMS.

},
"time": {
"from": "now-5m",
"to": "now"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to 'now-1m' so your dashboard always starts with the 1 minute window option which is ideal for our sampling speed. 5 minutes is too long and Grafana cannot show all the datapoints in a 5 minute window (you will see a red X in a triangle in the corner of your panels as a result).

"from": "now-5m",
"to": "now"
},
"timepicker": {},

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For timepicker look at what the other dashboards have and copy that. You need to have a "1s" option to refresh Grafana at 1s. I recommend you try "500ms, for example to see if it lets you (im unsure about this).

},
"timepicker": {},
"timezone": "",
"title": "BMS Dashboard",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change this title to follow the standard outlined in GRAFANA.md.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants