Cornering model#19
Draft
jonahjlee wants to merge 2 commits into
Draft
Conversation
… used in calculations should be modified for V4)
jonahjlee
commented
Jul 11, 2026
jonahjlee
left a comment
jonahjlee
left a comment
Contributor
Author
There was a problem hiding this comment.
Adding some miscellaneous comments after looking through your code in motor. I know you're still working on things so don't worry if I've said something you already know!
| self.COG_height = 0.5 #meters, arbitrary value for now | ||
|
|
||
|
|
||
| def get_slip (self, IMU_lateral_acceleration, ): |
Contributor
Author
There was a problem hiding this comment.
Suggested change
| def get_slip (self, IMU_lateral_acceleration, ): | |
| def get_slip(self, IMU_lateral_acceleration): |
| class V3CorneringModel(BasicMotor): | ||
| def __init__(self, left: bool, front: bool, **kwargs): | ||
| super().__init__(**kwargs) | ||
| self.tire_stiffness = 50000 #arbitrary value for now |
Contributor
Author
There was a problem hiding this comment.
Minor formatting convention - leave one space after the # for each comment
Contributor
Author
There was a problem hiding this comment.
can we rename this file to v3_cornering_model.py?
| """ | ||
| total_load = self.vehicle_mass | ||
|
|
||
| if (self.front_side == True): |
Contributor
Author
There was a problem hiding this comment.
you can just do if (self.front_side): instead of comparing to True here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creating a draft PR so that the diff can be viewed easily and so that we can provide comments.