Repository navigation
auto generate merchant id - #2009
StuartFerguson wants to merge 1 commit into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 346add4eb6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| } | ||
|
|
||
| public static Guid GenerateMerchantId(Guid estateId, String merchantName) { | ||
| String normalisedMerchantName = merchantName.ToLowerInvariant().Replace(" ", String.Empty); |
There was a problem hiding this comment.
When a creation request omits Name or explicitly sets it to null, GenerateMerchantId now throws at merchantName.ToLowerInvariant() before the existing validation in MerchantAggregate.Create can run. CreateMerchant catches that exception and returns Result.Failure instead of the previous Result.Invalid("Merchant name must be provided when registering a new merchant"). Validate the name before generating the ID so malformed requests retain the existing validation behavior.
Useful? React with 👍 / 👎.
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
No description provided.