Repository navigation
Auto Generate Estate Id - #2008
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 151ef8df68
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| } | ||
|
|
||
| public static Guid GenerateEstateId(String estateName) { | ||
| String normalisedEstateName = estateName.ToLower().Replace(" ", String.Empty); |
There was a problem hiding this comment.
When a create-estate request omits EstateName or explicitly sets it to null, estateName.ToLower() throws before EstateAggregate.Create can perform its existing String.IsNullOrEmpty validation. EstateDomainService.CreateEstate catches that exception and returns a generic failure instead of the previous Result.Invalid with the required-name message. Validate the name before generating the ID so malformed requests retain the intended validation result.
Useful? React with 👍 / 👎.
Auto Generate Estate Id